ci: run every non-browser test suite in the unit gate - #77
Closed
matej21 wants to merge 1 commit into
Closed
Conversation
`bun run test` enumerated the directories it covered, so 20 test files never ran in CI: the bindx-form, bindx-uploader and bindx-generator package suites plus tests/bindx-client and tests/repeater. The has-many materialisation bug fixed in #76 sat failing in packages/bindx-form/tests the whole time, behind a green board. Use an ignore pattern instead of an allow-list, so a new test directory is covered by default and cannot silently drop out again. Drop test:all, which now differs only by also running tests/browser and fails without a live playground. Gate: 1531 tests across 129 files -> 1737 across 149, 0 fail.
This was referenced Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gap
bun run test— the command CI's Unit & Integration Tests job runs — enumerated the directories it covered:Everything outside that list was invisible to CI. On
mainthat is 20 test files / 206 tests:packages/bindx-form/testspackages/bindx-uploader/testspackages/bindx-generator/teststests/bindx-clienttests/repeaterThis is not hypothetical. The has-many materialisation bug fixed in #76 was a failing test in
packages/bindx-form/tests/formRelations.test.tsx, and the board stayed green over it.The fix
Invert the selection: run everything, exclude only
tests/browser(which needs a live playground and has its owntest:browserjob).An allow-list drifts every time someone adds a directory — that is exactly how this happened. An ignore pattern covers new test directories by default.
test:allis dropped: it now differs fromtestonly by also runningtests/browser, so it fails for anyone without a playground running.Verification
Full gate run locally under a CPU lease, on this branch:
No test needed fixing — the newly covered suites were already green once #76 landed.
What this does not cover
tests/browseris still gated separately by the Browser Tests job, unchanged.