Skip to content

New branch for removing gogo/protobuf #97

Description

@kzys

I've been working on upgrading protobuf packages in containerd. Now Protobuild supports new protoc-gen-go and #96 will add new protoc-gen-go-ttrpc which should be able to generate ttrpc code that works with the new protoc-gen-go.

However, next few PRs will make some backward-incompatible changes, namely

  • Removing gogo/protobuf from ttrpc itself
  • Updating example/

Since ttrpc is used by containerd which has relatively long support policy, we would make some enhancements such as #75 and #94. So I'm reluctant to make ttrpc's main branch incompatible with gogo/protobuf right now.

Instead, could we have a branch to remove gogo/protobuf? If so, do we want to do Go-style branching (e.g. v2) instead of containerd-style (release/1.0)?

Activity

  1. dmcgowan commented on Oct 26, 2021

    @dmcgowan
    Member

    I think a release/1.0 branch is reasonable. This is what we have done in other dependent projects as well

  2. kzys commented on Oct 26, 2021

    @kzys
    MemberAuthor

    Sounds good to me. Let me clean up open PRs. I'd like to merge 1.0.x enhancements before cutting the branch.

  3. dcantah commented on Jan 29, 2024

    @dcantah
    Member

    Should this be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions