Add time type conversion for 32 bit linix platforms - #105
Merged
Merged
Conversation
Ensures the time.Unix function is given int64 arguments Signed-off-by: Trevor Porter <trkporter@ucdavis.edu>
stevvooe
suggested changes
Feb 16, 2018
| // StatATimeAsTime returns st.Atim as a time.Time | ||
| func StatATimeAsTime(st *syscall.Stat_t) time.Time { | ||
| return time.Unix(st.Atim.Sec, st.Atim.Nsec) | ||
| return time.Unix(int64(st.Atim.Sec), int64(st.Atim.Nsec)) // nolint: unconvert |
Member
There was a problem hiding this comment.
Include a comment here why these conversions are necessary. Otherwise, they may get removed.
Contributor
There was a problem hiding this comment.
@stevvooe I'm willing to address this in a follow up PR, but if you don't want it, I'm okay opening a carry-PR, just let me know.
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures the time.Unix function is given int64 arguments. I'm running 32 bit Debian 9.1-- this fixes the following error when building
containerdafter this PR added the continuity fs package tocontainerd:I recently had a PR merged for pretty much the same fix in the
containerdrepo