Localizing ClassPresentationUtil by unv-unv · Pull Request #312 · consulo/consulo-java

unv-unv · 2026-10-09T23:01:46Z

No description provided.

unv-unv · 2026-10-09T23:02:06Z

@claude review pr with inline comments

github-actions · 2026-10-09T23:02:25Z

Claude finished @unv-unv's task in 1m 54s —— View job

PR review: Localizing ClassPresentationUtil

Gather context
Review diff (17 files)
Post inline comments (review)
Final summary

Moving getNameForClass and getFunctionalExpressionPresentation over to LocalizeValue looks correct. I compared getContextName with the old code: it skips null or empty names the same way as before.

I posted 6 inline comments. Most include one-click suggestions.

Should fix

Two call sites still pass the new LocalizeValue where a String is expected, so the text depends on LocalizeValue.toString(). Every other call site uses .get().
- JavaMethodNode.java:82: buffer.append(getNameForClass(...))
- StaticImportMethodQuestionAction.java:250: getNameForClass(...) + "." + .... This line is outside the diff, so I couldn't attach a suggestion to it; the fix is written in the comment on line 247.

Nits

ClassPresentationUtil.java:94: after isNotEmpty(), getNullIfEmpty() adds nothing; get() is enough.
ClassPresentationUtil.java:105: the localizeTODO text has the context name baked in. When a real key is added, it should take the context as an argument. The text still shows "... in null" when there is no context, as it did before this PR.
PsiFieldFavoriteNodeProvider.java:121: this still uses ModuleUtilCore, while the Class and Method providers were switched to getModule() in this PR.
ClassPresentationProvider.java:56: packageName.length() == 0 could be isEmpty().

I didn't build the project, so I haven't confirmed that the LanguageLocalize keys used here (enumConstantContext, anonymousClassContextDisplay, classContextDisplay, methodContextDisplay) exist in the platform version this branch depends on.

github-actions

Review by Claude — see inline comments. Overall the migration to LocalizeValue looks good; two call sites were missed and still rely on implicit LocalizeValue.toString().

github-actions · 2026-10-09T23:04:19Z

+        StringBuilder buffer = new StringBuilder(128);
+        PsiClass containingClass = myMethod.getContainingClass();
+        if (containingClass != null) {
+            buffer.append(ClassPresentationUtil.getNameForClass(containingClass, false));


getNameForClass now returns LocalizeValue, so this compiles via StringBuilder.append(Object) and depends on LocalizeValue.toString(). Every other call site in this PR uses .get() explicitly. It's safer and more consistent to do the same here:

Suggested change

buffer.append(ClassPresentationUtil.getNameForClass(containingClass, false));

buffer.append(ClassPresentationUtil.getNameForClass(containingClass, false).get());

github-actions · 2026-10-09T23:04:19Z

    }

+    @RequiredReadAction
    private String getElementPresentableName(T element) {


Same issue at line 250, which is just outside the diff so I can't attach a suggestion to it. return ClassPresentationUtil.getNameForClass(aClass, false) + "." + element.getName(); now concatenates a LocalizeValue and so depends on its implicit toString(). Use .get() explicitly, like the other call sites:

return ClassPresentationUtil.getNameForClass(aClass, false).get() + "." + element.getName();

github-actions · 2026-10-09T23:04:19Z

+            }
+            LocalizeValue name = getNameForElement(parent, qualified);
+            if (name.isNotEmpty()) {
+                return name.getNullIfEmpty();


Nit: the isNotEmpty() check already passed, so getNullIfEmpty() can't return null here. get() is clearer:

Suggested change

return name.getNullIfEmpty();

return name.get();

github-actions · 2026-10-09T23:04:19Z

-  }
+    @RequiredReadAction
+    public static LocalizeValue getFunctionalExpressionPresentation(PsiFunctionalExpression functionalExpression, boolean qualified) {
+        return LocalizeValue.localizeTODO("Functional expression in " + getContextName(functionalExpression, qualified));


Nit: localizeTODO with a concatenated string bakes the context name into the untranslated text. Leaving this as a TODO is fine. When a key is added, it should take the context name as an argument (e.g. functional.expression.in.context, with getContextName passed through StringUtil.notNullize) so translators get one stable template. A small related point: if getContextName returns null, this still renders "Functional expression in null". That's how it behaved before this PR too.

github-actions · 2026-10-09T23:04:19Z

+        if (element instanceof PsiField) {
+            Module module = ModuleUtilCore.findModuleForPsiElement((PsiField) element);


Consistency: PsiClassFavoriteNodeProvider and PsiMethodFavoriteNodeProvider were switched to getModule() in this PR, but this one still uses ModuleUtilCore. Suggest aligning them (the ModuleUtilCore import can then be dropped):

Suggested change

if (element instanceof PsiField) {

Module module = ModuleUtilCore.findModuleForPsiElement((PsiField) element);

if (element instanceof PsiField field) {

Module module = field.getModule();

github-actions · 2026-10-09T23:04:19Z

+                PsiFile file = psiClass.getContainingFile();
+                if (file instanceof PsiClassOwner classOwner) {
+                    String packageName = classOwner.getPackageName();
+                    if (packageName.length() == 0) {


Nit: since this block is being reformatted anyway, use isEmpty(). PsiClassListCellRenderer.getContainerTextStatic does the same thing and already uses it:

Suggested change

if (packageName.length() == 0) {

if (packageName.isEmpty()) {

unv-unv · 2026-10-09T23:13:58Z

@claude review pr with inline comments

github-actions · 2026-10-09T23:14:18Z

Claude finished @unv-unv's task in 58s —— View job

PR review: Localizing ClassPresentationUtil

Gather context
Check the current head (513d146) against the 6 inline comments from the earlier review
Re-review the full diff (17 files) for anything new
Final summary

The earlier inline comments no longer match the code. The current head already contains five of the six fixes, so I didn't post them again:

Earlier comment	Status at `513d146`
`JavaMethodNode.java:82` was missing `.get()`	✅ It already calls `.get()`
`StaticImportMethodQuestionAction.java:250` was missing `.get()`	✅ It already calls `.get()`
`ClassPresentationUtil.getContextName` used `getNullIfEmpty()`	✅ It returns `name.get()` and is annotated `@Nullable`
`PsiFieldFavoriteNodeProvider` used `ModuleUtilCore`	✅ It uses `field.getModule()`, like the Class and Method providers
`ClassPresentationProvider` used `length() == 0`	✅ It uses `isEmpty()`
`getFunctionalExpressionPresentation` uses `localizeTODO`	⏳ Still open, see below

Those five threads are outdated and can be resolved.

All 22 call sites of getNameForClass and getFunctionalExpressionPresentation now handle the LocalizeValue correctly. Every caller that needs a String calls .get(). Two callers keep the LocalizeValue on purpose:

GutterIconTooltipHelper calls .get() itself when it builds the tooltip text.
ClassHierarchyScopeDescriptor.java:77 passes it straight into IdeLocalize.scopeHierarchy(...) as an argument, which is fine.

Still open (nit, no new inline comment): ClassPresentationUtil.java:106

The localizeTODO text still has the context name built into it, so translators won't get one fixed message with a placeholder.
When there is no context, it still shows "Functional expression in null", as it did before this PR.

The existing inline thread on that line covers both points.

No new problems found. I didn't post any new inline comments because the diff has nothing new to fix. I didn't build the project, so I haven't checked that the LanguageLocalize keys used here (enumConstantContext, anonymousClassContextDisplay, classContextDisplay, methodContextDisplay) exist in the platform version this branch builds against.

github-actions Bot reviewed Oct 9, 2026

View reviewed changes

Localizing ClassPresentationUtil.

513d146

unv-unv force-pushed the localizing-class-presentation-util branch from a79253d to 513d146 Compare October 9, 2026 23:13

VISTALL merged commit 87255c3 into consulo:master Oct 10, 2026
1 check passed

unv-unv deleted the localizing-class-presentation-util branch October 10, 2026 10:33

Navigation Menu

Repository navigation

Localizing ClassPresentationUtil - #312

Localizing ClassPresentationUtil#312
VISTALL merged 1 commit into
consulo:masterfrom
unv-unv:localizing-class-presentation-util

unv-unv commented Oct 9, 2026

Uh oh!

unv-unv commented Oct 9, 2026

Uh oh!

github-actions Bot commented Oct 9, 2026 •

edited

Loading

Uh oh!

github-actions Bot left a comment

Uh oh!

github-actions Bot Oct 9, 2026

Uh oh!

github-actions Bot Oct 9, 2026

Uh oh!

github-actions Bot Oct 9, 2026

Uh oh!

github-actions Bot Oct 9, 2026

Uh oh!

github-actions Bot Oct 9, 2026

Uh oh!

github-actions Bot Oct 9, 2026

Uh oh!

unv-unv commented Oct 9, 2026

Uh oh!

github-actions Bot commented Oct 9, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	buffer.append(ClassPresentationUtil.getNameForClass(containingClass, false));
	buffer.append(ClassPresentationUtil.getNameForClass(containingClass, false).get());

		if (element instanceof PsiField) {
		Module module = ModuleUtilCore.findModuleForPsiElement((PsiField) element);

	if (packageName.length() == 0) {
	if (packageName.isEmpty()) {

Conversation

unv-unv commented Oct 9, 2026

Uh oh!

unv-unv commented Oct 9, 2026

Uh oh!

github-actions Bot commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR review: Localizing ClassPresentationUtil

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 9, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 9, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 9, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 9, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 9, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 9, 2026

Choose a reason for hiding this comment

Uh oh!

unv-unv commented Oct 9, 2026

Uh oh!

github-actions Bot commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR review: Localizing ClassPresentationUtil

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Oct 9, 2026 •

edited

Loading

github-actions Bot commented Oct 9, 2026 •

edited

Loading