Repository navigation
Fix test-only compile error from missing cover_percent field - #652
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainis currently red:cargo testfails to compile witherror[E0063]: missing fieldcover_percentin initializer ofapp::ProgramViewMemory`` (introduced by Clean up Program state when a session is deleted #650, which left a test literal out of sync with thecover_percentfield Add resizable roll-down Program view #651 added).ProgramViewMemoryliteral indeleting_a_session_clears_its_program_state, using the samePROGRAM_COVER_PERCENT_DEFAULTthe rest of the test suite uses.Test plan
cargo test -p agentd-cli deleting_a_session_clears_its_program_statepasses locally