Skip to content

fix: network support for cdp wallets - #833

Merged
CarsonRoscoe merged 2 commits into
mainfrom
fix/cdp-wallet-network-support
Sep 3, 2025
Merged

CarsonRoscoe merged 2 commits into
mainfrom
fix/cdp-wallet-network-support

Conversation

@CarsonRoscoe

@CarsonRoscoe CarsonRoscoe commented Sep 2, 2025 •

Copy link
Copy Markdown
Contributor

Description

Fixed CDP wallet network mappings.

Python

Fixed network support in CDP wallet providers. Was only working on base-sepolia and ethereum-sepolia. Was failing on supported mainnets.

Typescript

Expanded supported CDP wallet mapping beyond just base-sepolia and base. Added ethereum, ethereum-sepolia, polygon, arbitrum and optimism networks.

Checklist

A couple of things to include in your PR for completeness:

  • Added a changelog entry

@cb-heimdall

cb-heimdall commented Sep 2, 2025 •

Copy link
Copy Markdown

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@github-actions github-actions Bot added documentation Improvements or additions to documentation wallet provider New wallet provider python typescript labels Sep 2, 2025
@CarsonRoscoe
CarsonRoscoe marked this pull request as ready for review September 2, 2025 13:07
@phdargen

phdargen commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

Cool, since when are those networks supported? Might be good to bump the cdp-sdk version (python), seems a bit outdated

@CarsonRoscoe CarsonRoscoe left a comment •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phdargen Good point. Here is the list of supported networks. Python side is at >1.22.0 while Typescript side is >1.36.0.

As of 1.22.0, the earlier of the two, the tagged commit is here. Seems these networks were already supported back then. So we shouldn't have to do an update.

However, it wouldn't hurt to do an update, specifically in Python where we've fallen behind a bit. Will still bump

@CarsonRoscoe
CarsonRoscoe requested a review from 0xRAG September 3, 2025 12:08
@CarsonRoscoe
CarsonRoscoe merged commit 510dc2a into main Sep 3, 2025
@CarsonRoscoe
CarsonRoscoe deleted the fix/cdp-wallet-network-support branch September 3, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation python typescript wallet provider New wallet provider

Development

Successfully merging this pull request may close these issues.

4 participants