Skip to content

feat: python/create-onchain-agent - improved cli network selection & template selection - #498

Merged
CarsonRoscoe merged 10 commits into
mainfrom
feat/py-cli-network-selection
Mar 3, 2025
Merged

CarsonRoscoe merged 10 commits into
mainfrom
feat/py-cli-network-selection

Conversation

@CarsonRoscoe

@CarsonRoscoe CarsonRoscoe commented Mar 3, 2025 •

Copy link
Copy Markdown
Contributor

Description

The main focus of this PR is to print it up to parity with #485.

In addition, this:

  1. Bumps the cli to use the Python AgentKit version 0.1.4 (needed for improved custom chainId/rpcUrl handling via feat(py): configurable eth account wallet provider rpc_url #474 )
  2. Improves local development of the cli by passing in a --template flag, which allows you to point to a local template instead of downloading the template from git.

Tests

Manual testing down the branches, both with and without the template flag

To manually test, from python/create-onchain-agent run:

poetry install
poetry build
poetry run python3.10 ./create_onchain_agent/cli.py --template ./templates/chatbot

@cb-heimdall

cb-heimdall commented Mar 3, 2025 •

Copy link
Copy Markdown

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@CarsonRoscoe
CarsonRoscoe marked this pull request as ready for review March 3, 2025 14:32
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Mar 3, 2025
@0xRAG 0xRAG added apple and removed needs triage labels Mar 3, 2025
Comment thread python/create-onchain-agent/templates/chatbot/pyproject.toml.jinja Outdated
Comment thread python/create-onchain-agent/templates/chatbot/chatbot.py.jinja Outdated
Comment thread python/create-onchain-agent/templates/chatbot/chatbot.py.jinja
Comment thread python/create-onchain-agent/create_onchain_agent/cli.py

@click.command()
def create_project():
@click.option('--template', type=str, help='Path to local template directory', default=None)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this new option be documented?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh nvm, just saw in the PR description that this is local-only

@CarsonRoscoe
CarsonRoscoe requested a review from 0xRAG March 3, 2025 20:40

@0xRAG 0xRAG left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CarsonRoscoe
CarsonRoscoe merged commit b32055b into main Mar 3, 2025
@CarsonRoscoe
CarsonRoscoe deleted the feat/py-cli-network-selection branch March 3, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apple documentation Improvements or additions to documentation python

Development

Successfully merging this pull request may close these issues.

3 participants