Repository navigation
fix: viem chainId from number to string - #294
Merged
John-peterson-coinbase merged 1 commit intoFeb 7, 2025
Merged
Conversation
✅ Heimdall Review Status
|
John-peterson-coinbase
approved these changes
Feb 7, 2025
emiridbest
pushed a commit
to emiridbest/agentkit
that referenced
this pull request
Feb 9, 2025
gtspencer
pushed a commit
to gtspencer/agentkit
that referenced
this pull request
Feb 13, 2025
Signed-off-by: Spencer <spencerobsitnik@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
One-liner: viem's chainId is a number, agentkit expects a string
Qualified Impact
Avoids potential footgun when action providers are checking networks e.g. in this line