Repository navigation
fix: use cdp wallet as account in call to estimateGas - #283
Merged
Merged
Conversation
✅ Heimdall Review Status
|
John-peterson-coinbase
approved these changes
Feb 6, 2025
Contributor
|
Thanks for the contribution! We require commits to be signed before merging. Please follow the instructions and then rebase to signed commits |
debuggingfuture
force-pushed
the
master
branch
2 times, most recently
from
February 6, 2025 20:26
69e10ee to
92d194c
Compare
debuggingfuture
force-pushed
the
master
branch
from
February 6, 2025 20:28
92d194c to
95f50ae
Compare
7 tasks done
emiridbest
pushed a commit
to emiridbest/agentkit
that referenced
this pull request
Feb 9, 2025
gtspencer
pushed a commit
to gtspencer/agentkit
that referenced
this pull request
Feb 13, 2025
Signed-off-by: Spencer <spencerobsitnik@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
For #238 Seems the fix #253 use
#publicClient.accountwhich is always undefinedQualified Impact
tested with approve erc20 txn. happy to add if there are plans for integration tests