Skip to content

Fix python example link - #230

Merged
jazz-cb merged 1 commit into
coinbase:masterfrom
thomasmetta:fix-python-example-link
Feb 1, 2025
Merged

jazz-cb merged 1 commit into
coinbase:masterfrom
thomasmetta:fix-python-example-link

Conversation

@thomasmetta

Copy link
Copy Markdown
Contributor

What changed? Why?

The pervious agentkit/python/cdp-langchain/examples/chatbot-python directory is no longer there and the folder location is updated

Qualified Impact

@cb-heimdall

cb-heimdall commented Feb 1, 2025 •

Copy link
Copy Markdown

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

jazz-cb
jazz-cb previously approved these changes Feb 1, 2025
@jazz-cb

jazz-cb commented Feb 1, 2025

Copy link
Copy Markdown
Contributor

@thomasmetta we need commits to be signed in order to merge the PR. Could you push a signed commit https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits ?

@thomasmetta

Copy link
Copy Markdown
Contributor Author

@thomasmetta we need commits to be signed in order to merge the PR. Could you push a signed commit https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits ?

Thanks, pushed a new signed verified commit

@thomasmetta
thomasmetta requested a review from jazz-cb February 1, 2025 22:27
@thomasmetta

Copy link
Copy Markdown
Contributor Author

Going to amend my first unsigned commit

@thomasmetta
thomasmetta force-pushed the fix-python-example-link branch from ab7ae4b to 2930bd6 Compare February 1, 2025 22:40
@thomasmetta
thomasmetta requested a review from jazz-cb February 1, 2025 22:41
@jazz-cb
jazz-cb merged commit 048cc00 into coinbase:master Feb 1, 2025
@thomasmetta
thomasmetta deleted the fix-python-example-link branch February 1, 2025 22:52
murrlincoln pushed a commit to murrlincoln/agentkit that referenced this pull request Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants