You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Apr 28, 2020. It is now read-only.
Repository navigation
This repository was archived by the owner on Apr 28, 2020. It is now read-only.
This would display all of the hosts, we could split by \n, then use the endpoints there?
Note:
This would mean that if any of the repositories were on GitHub, this would happen. Although, it is likely that if it is, then there is no problem.
I think it'd be much easier to just parse the output of git directly as roberthmiller pointed out, as if they're working with Git in the first place it's very likely that they have git installed on their system.
So, what do you think that the solution should be? Should we have a regex for the remotes? If there is a GitHub* remote, we should use it. Is that an ideal solution? Although, this solution is not very good since you can have a remote that looks like git:cdr/sail and it would be aliased as github.com in the ssh config. What are your thoughts on this?
I think just parse the output of git remote -v if git is exists, and if it has a URL beginning with https://github.com/ or git@github.com: then try to get the language from GitHub. If people have aliased GitHub to something else it won't work, but I don't think many people do that anyways.
Activity
teddy-codes commentedon May 23, 2019
/cc @nathanpotter @ammario
What are your thoughts on this?
Re: #196
nathanpotter commentedon May 23, 2019
I think it'd be better to just verify that the repo host is github before making the call to the API
teddy-codes commentedon May 24, 2019
will throw together a PR tomorrow.
coadler commentedon May 24, 2019
This might be tricky since you'll have to parse the
.gitfolder in the project for the hostteddy-codes commentedon May 24, 2019
Can't we just add a regex for github.com?
coadler commentedon May 24, 2019
I think that sets a bad precedent if we want to add logic based on the host
teddy-codes commentedon May 24, 2019
I think this will actually be kind of tricky now that you bring it up.
What are your thoughts on how to proceed?
coadler commentedon May 24, 2019
I think a good first step would be to see how janky extracting the host from the
.gitfolder would beteddy-codes commentedon May 24, 2019
wouldn't we be able to just run:
This would display all of the hosts, we could split by
\n, then use the endpoints there?Note:
This would mean that if any of the repositories were on GitHub, this would happen. Although, it is likely that if it is, then there is no problem.
deansheather commentedon May 24, 2019
.git/configis where git stores all of the remotes in a format that seems ini-ish:I think it'd be much easier to just parse the output of
gitdirectly as roberthmiller pointed out, as if they're working with Git in the first place it's very likely that they have git installed on their system.teddy-codes commentedon May 24, 2019
We could always check (although, a prerequisite to sail is git)
coadler commentedon May 24, 2019
teddy-codes commentedon May 24, 2019
So, what do you think that the solution should be? Should we have a regex for the remotes? If there is a GitHub* remote, we should use it. Is that an ideal solution? Although, this solution is not very good since you can have a remote that looks like
git:cdr/sailand it would be aliased as github.com in the ssh config. What are your thoughts on this?deansheather commentedon May 25, 2019
I think just parse the output of
git remote -vifgitis exists, and if it has a URL beginning withhttps://github.com/orgit@github.com:then try to get the language from GitHub. If people have aliased GitHub to something else it won't work, but I don't think many people do that anyways.teddy-codes commentedon May 25, 2019
ok, I will put together a PR together when I get sail to work on my mac (since I am away from my desktop).
teddy-codes commentedon Jun 20, 2019
@kami1019 Not sure what your problem is... Can you elaborate a little bit?