fix(codex): keep API keys out of rendered install scripts - #1075
Merged
DevelopmentCats merged 5 commits intoAug 26, 2026
Conversation
Edd88-pixel
marked this pull request as ready for review
August 24, 2026 16:20
Edd88-pixel
changed the title
matifali
removed their request for review
August 24, 2026 17:06
Co-authored-by: DevCats <chris@dualriver.com>
DevelopmentCats
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Codex module currently duplicates the API key into its rendered installation script and manually creates
auth.json. This leaves the secret in generated installation content and bypasses the CLI-supported authentication flow.Changes
auth.jsonmanually.codex login --with-api-key, passing the key through standard input from the workspace environment.5.3.2patch version.Validation
terraform test -no-color— 13 passed, 0 failed.bun test main.test.ts— 35 passed, 0 failed.Description
Secure CLI authentication and make installation failures explicit instead of allowing a partially configured workspace to appear successful.
Type of Change
Module Information
Path:
registry/coder-labs/modules/codexNew version:
v5.3.2Breaking change: [ ] Yes [x] No
Testing & Validation
bun test)Related Issues
None