fix(claude-code): propagate installation failures - #1063
Open
Edd88-pixel wants to merge 1 commit into
Open
Conversation
Edd88-pixel
marked this pull request as ready for review
August 19, 2026 18:26
DevelopmentCats
self-requested a review
August 20, 2026 16:50
35C4n0r
requested changes
Aug 25, 2026
| const { id, coderEnvVars, scripts } = await setup({ | ||
| skipClaudeMock: true, | ||
| moduleVariables: { | ||
| claude_binary_path: "/opt/claude/bin", |
Collaborator
There was a problem hiding this comment.
@Edd88-pixel the test resolved-pre-installed-binary-is-available-to-later-steps here is misleading, the mock claude binary is written to ~/.local/bin/claude and the path you are passing here is "/opt/claude/bin", so instead of using the preinstalled binary path the code flow from resolve_claude_binary uses the fallback "$HOME/.local/bin/claude"
35C4n0r
reviewed
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Claude Code installation failures could be logged while the module continued and reported success. The skip-install path could also complete without a usable pre-installed binary, leaving a workspace apparently configured while Claude Code was unavailable.
Changes
Validation