feat(web): open projects in px0 when installed - #10
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: codemode-studio/t3code/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe editor registry now includes Px0 with direct-path launching. The chat editor picker displays Px0 with its icon when available. Launcher tests cover the Linux installation path and PATH discovery on macOS and Windows, including non-shell launches. ChangesPx0 editor support
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to No actionable issue is established for this change; it is mergeable after normal checks. Px0 may leave a server running after its browser tab closes. Security Architecture ReviewSecurity architecture risk: 🟡 Moderate · up to Opening a project in px0 can leave a server running after the launch completes. The application does not manage that server’s lifetime, and the available evidence does not establish how its listener is protected. No exploitable exposure has been verified. Retained concerns
Security review detailsSecurity Blast Radius
Security Findings and Attack Paths
Trust Boundaries and Controls
Resilience and Maintainability Implications
Hardening Proposals
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
donald-purpose
left a comment
There was a problem hiding this comment.
Reviewed c4bf8eb against main at 1147aab.
Standards
One PR evidence item: please add before/after images showing the Open picker with px0 installed. Both AGENTS.md under Pull requests and CONTRIBUTING.md require images for UI changes. This PR adds a visible picker option and icon, but the description has no images. This is an evidence gap, not a functional defect.
No actionable code-standard violations found. The change follows the existing registry and picker patterns and includes focused launcher tests.
Spec
No actionable deviations from the PR description found. Discovery, labels, preferences, and launch arguments use the existing shared paths. Web and desktop share the picker; px0 stays excluded from remote-links mode because it has no remote scheme. Mobile and provider adapters need no changes for this picker addition.
Validation: launcher and editor-label tests passed, with 45 passed and 1 skipped. I also inspected px0 v0.1.4's target parser, which accepts file:line:column. No browser or real Windows launch verification was performed.
Standards: 1 evidence item, missing UI images. Spec: 0 findings.
Reviewed by GPT-6-Astra through the Codex harness.
The "Open" picker had no way to open a project or file in px0, a browser-based code review IDE.
px0 is added as an editor in
packages/contracts/src/editor.ts, so it appears in the picker whenever thepx0CLI is on the server's PATH. It launches aspx0 <path>. px0 acceptspath:linedirectly, so opening a file at a line from chat works too. The picker gets a small[0]brand icon.Notes:
px0from a terminal. px0 has no CLI option to reuse a running server.Works on macOS, Linux and Windows. On macOS and Windows, px0 is found on the PATH that server startup already fills in: from the login shell on macOS, and from known CLI folders such as
%USERPROFILE%\.local\binon Windows. On Linux it's also found in~/.local/binwhen that isn't on PATH.Tested:
externalLauncher.test.tshas new cases that discover px0 on PATH on macOS and Windows and in~/.local/binon Linux, and check that thepath:line:coltarget is passed unchanged. The launcher, editor label and contracts tests pass. Checked px0 v0.1.4's CLI by hand; the change hasn't been clicked through in a running app.Done by Claude Opus 5.5 in Claude Code.
🤖 Generated with Claude Code
Summary by CodeRabbit
px0.exe.