Skip to content

test(typescript): golden-fixture tests error instead of skipping when the gitignored fixture is absent (CI + fresh clones) #257

Description

@rahlk

PROBLEM

tests/analysis/typescript/test_typescript_analysis.py and test_typescript_neo4j_backend.py hard-depend on the golden fixture tests/resources/typescript/analysis_json/slim/analysis.json, which is gitignored — so on any fresh clone and in every CI run they produce ~23 collection-time FileNotFoundError ERRORS instead of clean skips. This is the bulk of the "failing tests" noise in the release workflow logs and masks real failures.

FIX CONTRACT

  1. Either commit/generate the fixture (deterministic generation step in conftest, cached), or gate the dependent tests with a presence-check skip marker exactly like the Neo4j live-DB gating in the same files.
  2. A fresh clone runs the TS suite with zero errors: pass or SKIP only.
  3. Coordinate with the release-gate issue: CI-green must be meaningful before the workflow gate flips to outcome.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    testAdded new tests

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions