Repository navigation
fix(artifacts): an unresolved receiver type is not a dispatch site, not a NullPointerException - #266
Merged
Merged
Conversation
…ot a NullPointerException (#265) Set.of(...).contains(null) throws, and a call node's receiver_type is null whenever the receiver did not resolve, so 3.3.0-3.3.2 crashed every unbuilt project with a forward/include/sendRedirect call at every level.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #265.
ViewDispatches.siteOflooked a possibly-nullreceiver_typeup inSet.of(...), which throws oncontains(null). A receiver is null whenever it did not resolve — an unbuilt project with notarget/and no Maven, a missing jar — so 3.3.0–3.3.2 crashed every such run with aforward/include/sendRedirectcall, at every level. Found by python-sdk'stest_java_degradation.pywhen its pin moved to 3.3.2 (python-sdk#404).Now a null receiver is simply not a site, which is the pre-3.3.0 behaviour (detection by declared receiver type; a degraded run reports no dispatches).
ViewDispatchesTest.anUnresolvableReceiverIsNotADispatchAndDoesNotCrashreproduces the NPE on the old code and passes with the guard. Full suite: 604 tests, only the Docker-only integration test unrun.