Repository navigation
fix(sdg): param_in/param_out carry the bound formal's var in JSON and on J_PARAM_IN/OUT - #250
Merged
Merged
Conversation
… on J_PARAM_IN/OUT The catalog declared `var` on J_PARAM_IN and J_PARAM_OUT and the projector emitted both with no properties, so a Cypher predicate on `r.var` went three-valued across every call boundary and silently dropped the path. The variable was already known where the edges are built — each actual binds a named callee formal — but JIdEdge had nowhere to carry it. JIdEdge.var now holds it: the bound parameter's name on param_in, `$ret` on param_out. Summary edges keep the bare shape (Gson omits an unset var rather than writing null). The conformance test now asserts every emitted edge of both types carries every declared property, on all of them rather than some — a partially present property is the same trap one step along. Same defect and same direction as codeanalyzer-python#195. Closes #249
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #249. Same defect and same direction as codeanalyzer-python#195 / codeanalyzer-python#196.
The catalog declared
varonJ_PARAM_INandJ_PARAM_OUTandV2GraphProjectoremitted both withRowBuilder.props()— no properties at all — so a Cypher predicate onr.varwent three-valued across every call boundary and silently excluded the path. The variable was already known where the edges are built:SdgVertices.addActualsAndEdgesbinds eachactual_in:ito a named callee formal and eachactual_outto the callee's@formal_out.JIdEdgejust had nowhere to carry it.JIdEdge.varnow holds it — the bound parameter's name onparam_in,$retonparam_out— and the projector writes it on every edge.summaryedges shareJIdEdgeand keep the bare shape; Gson runs withoutserializeNulls, so an unsetvaris omitted rather than written as null.Tests:
V2Neo4jSchemaConformanceTest.paramEdgesCarryEveryDeclaredPropertyasserts every emitted edge of both types carries every declared property — on all of them, not some, because a partially present property is the same trap one step along.SdgVerticesTestpins the two values (yand$ret) on thedataflow-testfixture.Gates:
./gradlew test— 562 of 563 pass. The one failure isCodeAnalyzerIntegrationTest :: initializationError, Testcontainers not finding a Docker environment on this machine; it fails identically onorigin/mainwithout this change.