Kotlin+Junit 5 Expect is not injected when using @Nested tests

When using nested tests, Expect is not injected into the outer class.

Example

@ExtendWith(SnapshotExtension::class)
class ExampleTest {

    lateinit var expect: Expect

    @Test
    fun foo() {
        expect.toMatchSnapshot("foo")
    }

    @Nested
    inner class MyNestedTest {
        @Test
        fun bar() {
            expect.toMatchSnapshot("bar") // Nullpointer `expect` is null
        }
    }
}

This can be worked around by defining expect in the inner class

Work around example

@ExtendWith(SnapshotExtension::class)
class ExampleTest {

    lateinit var expect: Expect

    @Test
    fun foo() {
        expect.toMatchSnapshot("foo")
    }

    @Nested
    inner class MyNestedTest {
        lateinit var expect: Expect
        @Test
        fun bar() {
            expect.toMatchSnapshot("bar") // Nullpointer `expect` is null
        }
    }
}

Personally, I think it would be the most intiutive / least boilerplate to inject at the class with the @ExtendWith(SnapshotExtension.class) annotation. Or maybe if possible, walk the class tree and inject into all classes.

@ross-paypay

Confirming this issue on Java+JUnit5. Thanks @ross-paypay for pointing out the workaround.

Another workaround is to use injected field, which unfortunately reports that it is deprecated for removal in v5, so that is not a stable way forward.

It seems like the issue is not restricted to Kotlin. I have the same problem using java.

I have a test for this is sure enough, expect is part of the nested class

https://github.com/origin-energy/java-snapshot-testing/blob/master/java-snapshot-testing-junit5/src/test/java/au/com/origin/snapshots/NestedClassTestWithExtends.java#L28

Navigation Menu

Repository navigation

Kotlin+Junit 5 Expect is not injected when using @Nested tests #158

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Kotlin+Junit 5 Expect is not injected when using @Nested tests #158

Description

Activity

Philzen commented on Oct 24, 2023

cponfick commented on Jul 12, 2024

jackmatt2 commented on Aug 8, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions