fix: Add retry logic and error handling for GPP key import (v0.2.8) - #66
fix: Add retry logic and error handling for GPP key import (v0.2.8)#66thomasrockhu-codecov wants to merge 3 commits into
Conversation
This commit addresses random CI/CD pipeline failures caused by intermittent GPG key import failures when downloading the verification key from keybase.io. Problem: - No error checking on curl command (silent failures) - No retry logic for network failures - No validation that the key was successfully downloaded - No error handling for GPG import failures Solution: - Added retry loop (3 attempts with 2-second delays) - Added explicit error checking for curl with -f flag - Added validation that downloaded key is not empty - Added error checking for GPG import operation - Added informative logging for each attempt Related: codecov/codecov-action#1876
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
=======================================
Coverage 97.14% 97.14%
=======================================
Files 2 2
Lines 35 35
=======================================
Hits 34 34
Misses 1 1 ☔ View full report in Codecov by Sentry. |
|
@thomasrockhu-codecov @calvin-codecov This looks good, we have seen this happening occasionally. Any release target to get this merged? |
| else | ||
| CODECOV_COMMAND="${CODECOV_CLI_TYPE}" |
There was a problem hiding this comment.
I don't see an earlier check to make sure CODECOV_COMMAND is guaranteed "codecov-cli" or "sentry-prevent-cli" here like in codecov.sh.
|
Any progress here? We're still experiencing this bug |
|
Bump |
1 similar comment
|
Bump |
|
@joseph-sentry any help here? |
|
@thomasrockhu-codecov any updates here? |
|
Those PRs themselves are closed though? |
|
@blimpich sorry, automation problem, I'll get this shipped by EOW |
Summary
Fixes random CI/CD pipeline failures caused by intermittent GPG key import failures when downloading the verification key from keybase.io.
Problem
This caused random CI/CD pipeline failures for all users, as the verification process would fail unpredictably when network issues occurred or when keybase.io was temporarily unavailable.
Solution
Testing
Related Issues
Release
This includes version bump to 0.2.8