Skip to content
This repository was archived by the owner on Jan 10, 2023. It is now read-only.

Handle builds triggered by AWS SDK. - #149

Merged
eddiemoore merged 2 commits into
codecov:masterfrom
aiell0:master
Jan 31, 2020
Merged

eddiemoore merged 2 commits into
codecov:masterfrom
aiell0:master

Conversation

@aiell0

@aiell0 aiell0 commented Sep 30, 2019 •

Copy link
Copy Markdown
Contributor

Introduction

Codebuild can be triggered by webhooks, or by resources inside the AWS cloud environment (such as lambda) via the AWS SDK. Upon triggering builds with the SDK inside Lambda, I was receiving the error documented inside #148. The intent of this PR is to resolve the issue.

Changelog

  1. lib/services/codebuild.js
    • Use git to find branch if not triggered by webhooks.
    • Send undefined pull request # if not triggered by webhook.
  2. test/services/codebuild.test.js
    • Add tests that mock git functionality.

@codecov

codecov Bot commented Sep 30, 2019 •

Copy link
Copy Markdown

Codecov Report

Merging #149 into master will increase coverage by 0.31%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
+ Coverage    89.8%   90.11%   +0.31%     
==========================================
  Files          23       23              
  Lines         353      354       +1     
  Branches       85       85              
==========================================
+ Hits          317      319       +2     
+ Misses         36       35       -1
Impacted Files Coverage Δ
lib/services/codebuild.js 100% <100%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7014d2...8acbe96. Read the comment docs.

@aiell0

aiell0 commented Oct 17, 2019

Copy link
Copy Markdown
Contributor Author

@eddiemoore Can we get this merged?

@eddiemoore
eddiemoore merged commit 7c4cdc4 into codecov:master Jan 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants