fix(ui): rules page layout on narrow viewports - #321
Merged
Conversation
- Header stacks: H1 stays on one line; project select (capped at 190px) and the New Rule action wrap to a second row instead of squeezing the title and causing 31px of horizontal overflow at 390px - Rule cards stack vertically below sm: actions drop under the rule text instead of crushing the title into a narrow column; badge row wraps; long webhook URLs break instead of overflowing - Swap the inline empty state for the shared EmptyState component
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
flex-wrap: H1 keeps one line; the project select is capped at 190px and wraps to a second row together with the + New Rule button on narrow screens (previously the title wrapped mid-word and the page had 31px of horizontal overflow at 390px)sm: Enable/Delete move under the rule text instead of compressing it into a ~90px column (the title was wrapping to 4 lines); badge row wraps; long webhook URLs nowbreak-allinstead of overflowingEmptyStatecomponent (missed during feat(ui): shared components, dialog confirms, toasts, sheet nav #317)Why
With several projects registered, the long project names in the selector pushed the header past the viewport and made the rules list unusable on phones — verified by the user on a 390px device.
Testing
scrollWidth - clientWidth = 0at 390px in dark and light (was 31px)npm run check0 errors,npm run buildpass