Skip to content

Fix intermittent overlay auto-hide #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Perecli wants to merge 1 commit into
base: firefox-port
Choose a base branch
from
Open

Fix intermittent overlay auto-hide #280

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions inject.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -889,16 +889,20 @@ function handleDrag(video, e) {
parentElement.addEventListener("mousemove", startDragging);
}

var timer = null;
function showController(controller) {
log("Showing controller", 4);
controller.classList.add("vcs-show");

if (timer) clearTimeout(timer);
// A page can contain multiple tracked media elements. Keep the timeout on
// the controller it belongs to so showing another controller cannot cancel
// this controller's pending hide.
if (controller.showTimeOut !== undefined) {
clearTimeout(controller.showTimeOut);
}

timer = setTimeout(function () {
controller.showTimeOut = setTimeout(function () {
controller.classList.remove("vcs-show");
timer = false;
controller.showTimeOut = undefined;
log("Hiding controller", 5);
}, 2000);
}