Repository navigation
Large PNG image fails to render in PR #94
Description
CodeApprove fails to render a large PNG image in a PR:
Inspecting the source, I see this tag for that image:
<img data-v-340c15f2="" src="data:image/png;none, " class="block m-auto">From Github it looks fine:
I notice that it's a very large image (1.74M), and CodeApprove seems to be inlining the image as base64, so maybe that's messing things up.
Here's the problem image as it appears in the source tree: https://p.tinypilotkvm.com/-UyhkwSMqFC/export-settings.png
Activity
samatcodeapprove commentedon Mar 31, 2023
@mtlynch thanks for reporting! I suspect GitHub has a limit (and I bet it's 1MB) above which I need to make a separate request for file content instead of getting it inline in the normal "pull request changes" API request. This shouldn't be too hard to fix.
samatcodeapprove commentedon Apr 12, 2023
@mtlynch deploying a fix for this now!
mtlynch commentedon Apr 12, 2023
Confirmed, thanks!