Skip to content

Trigger warning for unsaved edits before submitting review #86

Open

Description

@jotaen4tinypilot

After adding my comments for a review, I usually read over them again and often make some edits here and there to the comment copy, before submitting the review. Especially when the comment text boxes are toggled to preview mode, it’s easy to miss that a text change wasn’t saved yet. For me, it appears that if there are pending, unsaved comment changes, you can still submit the review, in which case it takes over the previous comment, not the unsaved, in-flight edit. (This happens regardless of whether the comment is rendered in preview-mode or not, though.)

It would be cool if CodeApprove would trigger a warning before accepting the review, to warn users that some of the comments have unsaved changes. Otherwise you might accidentally submit a potentially outdated version of the comment copy.

Activity

  1. samatcodeapprove commented on Jan 3, 2023

    @samatcodeapprove

    @jotaen4tinypilot thanks for this feedback! I agree, this would be a nice improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions