Skip to content

Allow comments on binary files #76

Closed

Description

@mtlynch

I'm reviewing a PR that includes image files. CodeApprove allows me to mark the image file as reviewed, but it doesn't allow me to attach comments to the file. I'd like to be able to comment on binary files sometimes, especially images and videos.

I don't need anything fancy like commenting on a particular part of the image/video. Just being able to make file-level comments would be sufficient.

Activity

  1. samatcodeapprove commented on Oct 21, 2022

    @samatcodeapprove

    Thanks for requesting this! This has been a long-awaited feature request but I forgot to migrate it to GitHub

  2. samatcodeapprove commented on Mar 31, 2023

    @samatcodeapprove

    You can now leave comments on whole files, including images and other binary files!
    https://www.loom.com/share/fb18cae8f9a6437184b6fa1130ef2c17

  3. mtlynch commented on Mar 31, 2023

    @mtlynch
    Author

    Awesome, that looks great. Thanks for adding this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions