Repository navigation
Minor request: Make Resolve toggle default state to be disabled by default when replying to a comment #118
Description
Hey, Sam. Finisterra Labs team back again with a small request if you think it makes sense.
We have an internal policy on PR reviews where the commenter is the one responsible for resolving the review comment when it has been successfully addressed. However, the current behavior when replying comments (where the Resolve toggle is automatically set when commenting) is leading to some of us to unintentionally resolving comments when replying to them (without it having been fully addressed).
Would it be possible to make the Resolve initial state to be disabled, and for the reviewer to have to explicitly mark the Resolve toggle or click Resolved after commenting to mark the comment as resolved. This would be of huge help for us, hopefully we don't break things for other. Let me know if you need any follow-up.
We really appreciate your support, as always. Cheers!
Activity
[-]Minor fix: `Resolve` toggle disabled by default when replying a comment[/-][+]Minor request: Make `Resolve` toggle default state to be disabled by default when replying to a comment[/+]samatcodeapprove commentedon Sep 6, 2024
@adlrocha I'm happy to make this into a repository setting. I've had other users feel strongly in exactly the opposite way so I can't change it globally. Adding this setting should be an easy fix!
Also (shameless plug) I also run https://gitguard.dev which is a tool to help you enforce any other policies you might have around PRs.
adlrocha commentedon Sep 6, 2024
This would be perfect. Thanks!
Will definitely look deeper into this. Cheers!
samatcodeapprove commentedon Sep 8, 2024
@adlrocha I am pushing a new build with this feature right now. If you go to the Settings page and expand your org under "Installations" you'll see a new toggle for each repo "Resolve threads by default?" which should default to true.
If you disable this, then the "Resolved" toggle will no longer default to being on for comment replies on that repository. Hopefully this solves your issue!
adlrocha commentedon Sep 9, 2024
Amazing. Thank you!