Repository navigation
CodeApprove shows changes requested after LGTM #101
Description
I gave some minor notes on a PR and gave approval, so I was expecting CodeApprove to auto-approve the PR after the remaining notes were resolved, but it's still showing changes requested on Github:
On CodeApprove, it says the change is approved:
Normally, I expected an auto-response from me saying, "All my issues are resolved, so I approve," but it isn't showing up.
Activity
samatcodeapprove commentedon Jun 6, 2023
@mtlynch thanks! Your expectation is correct. I can see in the backend logs that for some reason when I tried to sync your approval to GitHub I got a "bad credentials" error. I will have to look into why that is the case.
In the meantime I think the sync link at the bottom of the CA page should fix this for you (if you haven't already manually fixed this on GitHub)
mtlynch commentedon Jun 7, 2023
@samatcodeapprove - Ah, I forgot about that button. I'll keep that in mind next time.
cghague commentedon Jun 7, 2023
@samatcodeapprove - This pull request was still stuck in my CodeApprove inbox despite having being merged and closed. I can confirm that hitting the re-synchronize link fixed the issue.
mtlynch commentedon Jul 26, 2023
@samatcodeapprove - We just ran into this again on https://codeapprove.com/pr/tiny-pilot/tinypilotkvm.com/1000
Re-synchronizing fixed the issue.
samatcodeapprove commentedon Jul 28, 2023
@mtlynch gah I can't believe CodeApprove messed up on such an excellent PR number! I will dig.
samatcodeapprove commentedon Jul 28, 2023
Deploying a (speculative) fix for this now. I think I found a small race condition with how I'm using GitHub tokens but also given that this issue only happens once in a long while it will be hard to be sure! I'll monitor the logs.