-
Notifications
You must be signed in to change notification settings - Fork 626
Feature: Share the game link with Opponent #296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a7108c3
modify JOIN_ROOM message type
VK-RED 81466da
Create ShareGame Component
VK-RED b7d9e24
Add utility class to hide scrollbar
VK-RED a6c5972
Add ShareGame component
VK-RED 9a66faa
Merge main branch
VK-RED a63fccb
fix: merge conflicts
VK-RED 2415016
fix: socket manager instance
VK-RED 74aaf2d
fix: avoid utilizing useState for url
VK-RED File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| import { useState } from "react" | ||
| import { Button } from "./Button"; | ||
|
|
||
| export const ShareGame = ({className,gameId}:{className?:string,gameId:string}) => { | ||
|
|
||
| const url = window.origin+"/game/"+gameId; | ||
| const [copied,setCopied] = useState(false); | ||
|
|
||
| const handleCopy = ()=>{ | ||
| window.navigator.clipboard.writeText(url); | ||
| setCopied((p)=>true); | ||
| } | ||
|
|
||
| return ( | ||
| <div className={`flex flex-col items-center gap-y-4 ${className}`}> | ||
|
|
||
| <h3 className="scroll-m-20 text-4xl font-semibold tracking-tight text-green-500"> | ||
| Play with Friends | ||
| </h3> | ||
|
|
||
| <div className="flex items-center gap-x-2"> | ||
|
|
||
| <LinkSvg/> | ||
|
|
||
| <div onClick={handleCopy} className="text-blue-500 cursor-pointer"> | ||
| {url} | ||
| </div> | ||
| </div> | ||
|
|
||
| <Button onClick={handleCopy}> | ||
| {copied ? `Copied to Clipboard !!` : `Copy the link`} | ||
| </Button> | ||
| </div> | ||
| ) | ||
| } | ||
|
|
||
| const LinkSvg = () => { | ||
| return ( | ||
| <svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round" className="lucide lucide-link text-white"> | ||
| <path d="M10 13a5 5 0 0 0 7.54.54l3-3a5 5 0 0 0-7.07-7.07l-1.72 1.71"/><path d="M14 11a5 5 0 0 0-7.54-.54l-3 3a5 5 0 0 0 7.07 7.07l1.71-1.71"/> | ||
| </svg> | ||
| ) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this?
doesnt
const { gameId } = useParams();work?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No ser, that won't work. When the first player initially joins he will be at the route /game/random. After receiving the game_added message we will actually get the game ID, using which we create the link ..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, i see the login is different, would be better if we push the user who is wainting to the actual url with the ID: /game/id...
for now mergin this.