Skip to content

Tech backlog | Singleton implementation of Socket Manager #355

Description

@aadeshkulkarni

What is the purpose of this issue ?

  • Improve Singleton implementation for Sockets.

Value addition ?

  • Does it add any feature or fix any bug in the application ? > No.
  • Does it improve performance of the application ? > Probably not.
  • Does it improve code quality and maintainability ? > Yes.

What is this really about ?

SocketManager is implemented as a Singleton. The SocketManager.getInstance() is called frequently ( 9 times to be precise) in a lot of places unnecessarily.

Instead, we can now directly export SocketManager.getInstance() which points to the singleton instance.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions