refactor(discrete-curve): delegate DiscreteBondingCurve to SharedCoreKit - #731
Merged
Conversation
flipcash-shared-core-spm 0.6.0 renames SharedDiscreteCurve to SharedBondingCurve, which DiscreteBondingCurve.swift already expects. Bump the version floor in the three Package.swift manifests and the Xcode project's package reference, then re-resolve so Package.resolved picks up 0.6.0.
bmc08gt
marked this pull request as ready for review
September 11, 2026 20:00
…discrete-curve * origin/main: (27 commits) fix(database): share one SQLite writer per owner and take write locks up front (#759) feat(chat): declare the payment action on tip DM payments (#752) refactor(chat): drop the deprecated new_messages overlay (#757) feat(notifications): write prefetched messages into the shared store (#756) refactor(store): move the persistence layer into a shared FlipcashStore package (#755) feat(database): move the SQLite store into the App Group container (#754) feat(database): open the store on demand, close it on background (#753) feat(nse): extension crash reporting, a WAL checkpoint, and on-device push hooks (#751) feat(home): long-press the You tab to open the account switcher (#749) fix(tests): reset Photos access before the previous app instance lingers (#746) chore: bump version to 2026.9.2 (#745) revert: back out the Coinbase Stable Swapper authority migration (#747) (#750) fix(swap): follow the Coinbase Stable Swapper authority migration (#747) fix(tests): cancel a cash link through the details screen (#744) fix(chat): make the whole Send Cash pill tappable while it stands alone (#743) fix(username): drop a leading @ in the validator (#742) fix(chat): scope the send-button spring to the button (#741) fix(transactions): tighten the details card stack and drop the header badge (#740) fix(transactions): draw View in Chat as a card, not the primary action (#739) feat(chat): flash the message a reply-quote jump lands on (#738) ... # Conflicts: # Code.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # FlipcashCore/Package.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DiscreteBondingCurve.swift's low-level methods now delegate toSharedCoreKit.SharedDiscreteCurve; the high-levelbuy/sell/marketCapAPI is untouched.UInt128andDiscreteCurveTablestypes now that the shared module owns that logic.DiscreteBondingCurveTests.swiftthat asserted on the now-deleted internal types; equivalent coverage lives in the shared KMP module's own fixture-based tests.This is a draft:
SharedDiscreteCurvecurrently only exists via a manual copy into ephemeral build caches, not through a publishedflipcash-shared-core-spmrelease, so CI cannot build clean until the companion code-android-app PR merges and SharedCore is republished.