feat(currency-math): move discrete bonding curve engine to shared KMP module - #1423
Merged
Conversation
github-actions
Bot
added
type: feature
:libs:currency-math:discrete-curve uses com.android.kotlin.multiplatform.library
with withHostTest {}, so its Android-target unit tests run under
testAndroidHostTest, not testDebugUnitTest. It was missing from
kmpUnitTestModules in settings.gradle.kts, so it fell through to
androidUnitTestModules by default and the flipcashTestDebug aggregate task
looked for a testDebugUnitTest task that doesn't exist on it, failing CI's
Run Flipcash Tests job at dependency-resolution time.
:libs:currency-math:discrete-curve's test-fixture generator compiles two ~4.5MB base64 tables into a single ~8.7MB TestFixtures.kt on commonTest. apps:flipcash:app:lintDebug aggregates dependency modules' test sources straight off disk, and lint's PSI/UAST parser hard-caps source files around 20MB pre-escaping headroom, so it fails the whole build with "Source file too large for lint to process" on that generated file. Set ignoreTestSources on the module so lint drops its test sources from the aggregated scan; commonMain/androidMain are still checked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:libs:currency-math:discrete-curve, a new KMP commonMain module holding the discrete bonding curve engine (table parsing, high-precision arithmetic, binary-search/step pricing).curve.json/curve_fractional.jsonfixture vectors tocommonTest, plus avalueToTokens/tokensForValueExchangeedge-case gate.SharedCorevia aSharedDiscreteCurveKotlin/Native facade, with a cross-platform gate test.DiscreteBondingCurveto a thin adapter that delegates pricing to the shared engine and converts to/fromjava.math.BigDecimalat the boundary; the deletedLazyBigDecimalTable/TableLoaderare replaced byAndroidTableLoader/ClasspathTableLoader/FileTableLoader(TableByteLoader).This is one of two companion PRs — the other is in
code-ios-app— for the shared bonding-curve migration. Landing requires: this PR merging tocode/cash, then aSharedCorepublish (newflipcash-shared-core-spmversion), then the iOS PR's pin bump to that version.