Release 2.7.4 - #127
Release 2.7.4#127
Conversation
Resolve remaining WordPress.org review findings
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (12)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 48f62142a9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| $cc_term = get_term( $term_id ); | ||
| // Set the global term object (forward compatibility). | ||
| set_global( 'term', $cc_term ); | ||
| set_global( 'term', get_term( $term_id ) ); |
There was a problem hiding this comment.
Keep the recently deprecated term global synchronized
When an extension still reads the global $cc_term while Content Control evaluates a term query, this now leaves that global unset or pointing at a previous term while only the managed term value is updated, so custom conditions can evaluate against the wrong taxonomy term. This compatibility global was only deprecated in 2.7.1, whereas the 2.7.4 release notes say only APIs deprecated since 2.0 are being removed; retain the synchronization until a suitably announced breaking release.
Useful? React with 👍 / 👎.
| @@ -129,7 +129,6 @@ function plugin_instance() { | |||
|
|
|||
| if ( ! $plugin instanceof \ContentControl\Plugin\Core ) { | |||
| require_once __DIR__ . '/inc/functions.php'; | |||
There was a problem hiding this comment.
Regenerate the API stub after removing legacy declarations
Removing the deprecated loader here leaves bin/stubs/content-control.php inconsistent with the runtime: it still declares JP_Content_Control, JP\CC\Is, JP\CC\Site\Restrictions, and jp_content_control() (for example at lines 4256–4323 and 5757–5764). IDEs and static-analysis consumers using this tracked generated stub will therefore accept calls that now fail at runtime, so the stub should be regenerated as part of this API removal.
Useful? React with 👍 / 👎.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Summary
content-controltext domain for requirement noticesValidation
da5d89c0d61520292cc672dda4da549a733e4db4c908c27d6618519a3eac3a45composer.json, version 2.7.4, and no removed legacy files or declarationsSummary by CodeRabbit
Removed
Bug Fixes
Chores