You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Dashboard E2E: team-tab review-blocking test uses ambiguous locator #698
The Playwright test added in #695 (packages/codev/src/agent-farm/__tests__/e2e/team-tab.test.ts) fails on main under Playwright strict mode because its card selector matches multiple elements.
Failing test
Team tab: review-blocking rendering (spec 694) › renders both-direction sentences with a mocked /api/team response
The feature this PR shipped broke its own test: review-blocking text legitimately mentions the other person's name, so filtering cards by name substring is no longer unique.
Same issue applies to waleedCard.
Suggested fix
Use a more specific locator that matches the card by its identity rather than any text inside it:
Filter by the @amr / @waleed handle (rendered in .team-member-handle or similar), or
Use page.locator('.team-member-card').filter({ has: page.locator('h3', { hasText: 'Amr' }) }) or equivalent on whatever element renders the member's name as a heading.
Either makes the assertion robust to future content that may mention other members' names.
Impact
Blocks the scheduled Dashboard E2E workflow on main. The PR's own CI passed because the Dashboard E2E workflow runs on schedule, not on push/PR.
Activity
waleedkadous commentedon Apr 23, 2026
On it! Working on a fix now.
[Bugfix #698] Fix: disambiguate team-tab test card locator
Merge pull request #699 from cluesmith/builder/bugfix-698