more metadata options - #153
Conversation
|
sorry for a few more commits for tests, won't happen another time |
There was a problem hiding this comment.
It might be worth making these values, and the method validate_encoding part of the InitFile class itself, since this may not be the only class in this module that needs encoding validation going forward.
|
updated for comments |
|
Ok, for now I think this is good - I think in the future we may want to differentiate troposphere added 'Helper Functions' like these, and the built in ones (like Select, Join, etc). But I don't think that'll cause too much trouble for now. @markpeek are you ok with pulling this in without an example/test for this specific data type? Not sure how you're feeling about that in general - while it'd be awesome to have 100% coverage on all resources, not sure how much it'd actually help things. Thanks @iblazevic for the pull requests - these have been super useful. Once I hear back from @markpeek, I'll go ahead and merge! |
|
While it would be nice to have 100% example/test coverage across all of the troposphere classes, I don't believe we're there currently. So gating this commit for it seems punitive. Go ahead and merge. BTW, my basic philosophy is to use examples to mimic AWS CF example code and to provide code coverage for the AWS service. And then use tests to ensure correctness and general behavior (like validation code). |
|
Awesome - that's where I was leaning as well. Thanks @iblazevic! |
more metadata options
We use this for our cloudformation scripts so why not share