Skip to content

more metadata options - #153

Merged
phobologic merged 4 commits into
cloudtools:masterfrom
iblazevic:metadata_fixes
Dec 17, 2014
Merged

more metadata options#153
phobologic merged 4 commits into
cloudtools:masterfrom
iblazevic:metadata_fixes

Conversation

@iblazevic

Copy link
Copy Markdown
Contributor

We use this for our cloudformation scripts so why not share

  • more options added for InitFile, made content optional
  • added InitService and InitServices with an example of using it

@iblazevic

Copy link
Copy Markdown
Contributor Author

sorry for a few more commits for tests, won't happen another time

Comment thread troposphere/cloudformation.py Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth making these values, and the method validate_encoding part of the InitFile class itself, since this may not be the only class in this module that needs encoding validation going forward.

@iblazevic

Copy link
Copy Markdown
Contributor Author

updated for comments

@phobologic

Copy link
Copy Markdown
Member

Ok, for now I think this is good - I think in the future we may want to differentiate troposphere added 'Helper Functions' like these, and the built in ones (like Select, Join, etc). But I don't think that'll cause too much trouble for now.

@markpeek are you ok with pulling this in without an example/test for this specific data type? Not sure how you're feeling about that in general - while it'd be awesome to have 100% coverage on all resources, not sure how much it'd actually help things.

Thanks @iblazevic for the pull requests - these have been super useful. Once I hear back from @markpeek, I'll go ahead and merge!

@markpeek

Copy link
Copy Markdown
Member

While it would be nice to have 100% example/test coverage across all of the troposphere classes, I don't believe we're there currently. So gating this commit for it seems punitive. Go ahead and merge.

BTW, my basic philosophy is to use examples to mimic AWS CF example code and to provide code coverage for the AWS service. And then use tests to ensure correctness and general behavior (like validation code).

@phobologic

Copy link
Copy Markdown
Member

Awesome - that's where I was leaning as well. Thanks @iblazevic!

@phobologic phobologic closed this Dec 17, 2014
@phobologic phobologic reopened this Dec 17, 2014
phobologic added a commit that referenced this pull request Dec 17, 2014
@phobologic
phobologic merged commit d893c4f into cloudtools:master Dec 17, 2014
@iblazevic
iblazevic deleted the metadata_fixes branch December 18, 2014 09:51
Hons pushed a commit to Hons/troposphere that referenced this pull request Dec 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants