Conversation
- Remove aspectRatio constraint from wrapper div - Allows VideoJS fullscreen to work properly - Fixes issue where videos wouldn't fill screen in fullscreen mode Fixes #433
|
@ArjunCodess is attempting to deploy a commit to the Cloudinary DevX Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@eportis-cloudinary just a follow-up. |
Contributor
|
@ArjunCodess Your PR is still under review. Please be patient, we have several PRs to review! Thank you :) |
eportis-cloudinary
requested review from
strausr
and removed request for
eportis-cloudinary
October 20, 2025 16:47
strausr
approved these changes
Oct 21, 2025
strausr
left a comment
strausr
left a comment
Collaborator
There was a problem hiding this comment.
Nice catch and clean fix — thanks for contributing! 🎉
Collaborator
|
@all-contributors Please add @ArjunCodess for code |
Contributor
|
@ArjunCodess already contributed before to code |
strausr
added
hacktoberfest
hacktoberfest2025
hacktoberfest-accepted
and removed
under-review
labels
Collaborator
|
I've sent Arjun a swag invitation via Discord, all set |
|
🎉 This PR is included in version 6.16.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #433.
Description
Fixes the full-screen object-cover issue with CldVideoPlayer, where videos wouldn't properly fill the screen in full-screen mode. The wrapper div's
aspectRatioconstraint was interfering with VideoJS's fullscreen implementation, preventing videos from scaling correctly while poster images worked as expected.Root Cause: VideoJS handles aspect ratios internally through its own classes and styling system. The wrapper div's
aspectRatioCSS property was creating a constraint conflict when VideoJS attempted to move the video element to fullscreen (position: fixed).Solution: Removed the redundant
aspectRatioproperty from the wrapper div styling inCldVideoPlayer.tsx, allowing VideoJS's built-in fullscreen mechanism to work without constraint interference.Issue Ticket Number
Fixes #433
Type of change
Checklist
Files Changed
next-cloudinary/src/components/CldVideoPlayer/CldVideoPlayer.tsx- Removed aspectRatio constraint from wrapper div