[morganabc]

headers: These are byte strings of the exact byte sequences sent by the client/to be sent by the server. While modern HTTP standards say that headers should be ASCII, older ones did not and allowed a wider range of characters. Frameworks/applications should decode headers as they deem appropriate.
(https://asgi.readthedocs.io/en/latest/specs/www.html#wsgi-compatibility)

Workerd uses Pyodide JSProxy object when passing fetch(request, env) to Python, but JSProxy objects translates into string, not byte-string.

In order to match ASGI specification, it needs to be translated into byte-pair when building scopes.

[github-actions]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[morganabc]

I have read the CLA Document and I hereby sign the CLA

[hoodmane]

Code change makes sense. Ideally we ought to add a test.

[hoodmane]

In lieu of adding a test, can we add a comment here with an example that cares about this being bytes so that we can add a test ourselves later?

[morganabc]

It assumes FastAPI so that would be a main concern, but its for ASGI spec though so should I add for FastAPI or just asserting for spec?

Like, anything for

@app.get("/example")
  async def example(request: Request):
    request.headers.get("content-type") # this will error if header is not bytes.

perhaps?

[morganabc]

Also is there way to test this locally? I want to build miniflare with master workerd, but building workers-sdk doesnt works..

[hoodmane]

You can build workerd by itself and then set an environment variable to tell wrangler to use your custom build. @dom96 are there good instructions somewhere that we can point contributors to?

I guess I should check it out and test it myself...

[dom96]

May be easier to build and run workerd locally. These are probably the best instructions we have for doing this: https://github.com/cloudflare/workerd?tab=readme-ov-file#configuring-workerd.

We also have some sample Python worker configs in the repo already, for example https://github.com/cloudflare/workerd/tree/main/samples/pyodide-fastapi

[morganabc]

Oh, so I can use workerd directly! Thanks, now I can test few things.

[leobuskin]

That's not the only trouble w/ ASGI and binary strings. We also need to decode resulting headers in asgi.py, if I understand correctly:

async def send(got):
        ...
        if got['type'] == 'http.response.start':
            status = got['status']
            headers = [(k.decode(), v.decode()) for k, v in got['headers']]

[spikerwork]

That's not the only trouble w/ ASGI and binary strings. We also need to decode resulting headers in asgi.py, if I understand correctly:

async def send(got):
        ...
        if got['type'] == 'http.response.start':
            status = got['status']
            headers = [(k.decode(), v.decode()) for k, v in got['headers']]

Confirmed! This patch fixed the problem with b'' I've seen before

[morganabc]

That's not the only trouble w/ ASGI and binary strings. We also need to decode resulting headers in asgi.py, if I understand correctly:

async def send(got):
        ...
        if got['type'] == 'http.response.start':
            status = got['status']
            headers = [(k.decode(), v.decode()) for k, v in got['headers']]

Yes, right. I fixed it. Thanks!

[leobuskin]

@morgan9e I'd use double quotes here to be compliant w/ folks' formatting standards

[morganabc]

Working on it!

[hoodmane]

Since #2096 merged, we're actually running Python tests on workerd so it should be possible to add a test now.

[morganabc]

@hoodmane: Since #2096 merged, we're actually running Python tests on workerd so it should be possible to add a test now.

Should I add test for ASGI only or if its working with Starlette? I think it might be better if we make asgi.py independant to FastAPI

[hoodmane]

Agreed we should make it independent. Currently the only thing in there that is dependent on fastapi is Env. Perhaps we can just delete that for now and we can figure out the appropriate place to add it later.

[dom96]

Hey @morgan9e, would love to get this merged in, are you still planning to create a test for this?

[morganabc]

Hey @morgan9e, would love to get this merged in, are you still planning to create a test for this?

Yep, thanks I'll do it ASAP.

[morganabc]

Hey @morgan9e, would love to get this merged in, are you still planning to create a test for this?

Yep, thanks I'll do it ASAP.

I added the test, I wrote sample ASGI Application rather than using FastAPI because I thought it was better to seperate it from FastAPI.

[morganabc]

Sorry, I accidently merged and removed upstream branch, I reopened it. #3142