Repository navigation
Avoid repeating the skill installation safety warning - #14784
Merged
Merged
Conversation
Keep the pre-install disclaimer and present post-install review guidance without a second warning. Preserve pinned preview commands and cover local and remote output in TTY and non-TTY modes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c5ee8a8a-f0e8-432e-8ebb-62ff72712b41
tommaso-moro
requested review from
BagToad
and
a balanced review from Copilot
October 21, 2026 17:32
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Contribution eligibility remains unverified and needs confirmation from @cli/code-reviewers.
No open issues 🎉
What changed in this PR
Simplifies GitHub CLI skill installation output while preserving the pre-install safety disclaimer.
Changes:
- Replaces the repeated warning with plain review guidance on stderr.
- Preserves remote preview commands and adds local/remote regression coverage for TTY and non-TTY output.
| File | Description |
|---|---|
| pkg/cmd/skills/install/install.go | Simplifies post-install guidance for both installation paths. |
| pkg/cmd/skills/install/install_test.go | Checks warning count, output routing, and exact guidance formatting. |
Review effort: Balanced
babakks
approved these changes
Oct 22, 2026
This was referenced Oct 23, 2026
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Installing a skill prints a safety disclaimer before installation and repeats essentially the same warning afterward. Keep the full pre-install disclaimer and make the post-install message plain review guidance instead, for both local and remote installs.
How did you test this change?
I ran
makebefore and after the change; both builds passed. With isolated home, configuration, and destination directories, I used the newly builtbin/gh skill installwith--from-local --dirto install the same syntheticexampleskill. Both installs exited 0 and createdexample/SKILL.md. I saw two safety warnings before the change and one afterward, with the original pre-install disclaimer unchanged.The post-install stderr excerpts were:
Before:
After:
Key points
The safety disclaimer remains before installation rather than being removed entirely. Remote installs retain the
gh skill previewcommands pinned to the installed commit, including--allow-hidden-dirswhen needed. Local installs retain their file-review reminder. Review guidance stays on stderr.Notes for reviewers
Start with
printReviewHintinpkg/cmd/skills/install/install.go. Regression coverage checks that local and remote installs print the warning once in both TTY and non-TTY modes; exact-output tests preserve preview arguments and formatting. Remote behavior was covered with mocked API responses, not a live remote installation.go test ./pkg/cmd/skills/...go fix ./pkg/cmd/skills/installgo test ./...make lintAuthorship and follow-up
Who wrote this:
Who answers review comments: