-
Notifications
You must be signed in to change notification settings - Fork 474
fix(ui): update self-serve sso & directory sync to latest designs #9940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
400afeb
f47e011
99d869c
5230285
b83b59c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| --- | ||
| '@clerk/localizations': minor | ||
| '@clerk/shared': minor | ||
| '@clerk/ui': minor | ||
| --- | ||
|
|
||
| Update the SSO and Directory Sync sections of the `<OrganizationProfile />` Security page to the latest designs. Both sections now show a "Configure" button until something is set up (SSO then shows "Add connection"), and SSO connection rows show the identity provider's logo and an actions menu (Edit, Continue configuration, Activate/Deactivate, Remove). These actions have been removed from the SSO connection page, and status badges are no longer color-coded. Okta logos now follow the theme's foreground color, so they stay visible in dark mode, including on the enterprise connection chooser and in `<UserProfile />`. | ||
|
|
||
| The SSO button uses the new `ssoSection.primaryButton__configure` localization key; `ssoSection.primaryButton__startConfiguration` is deprecated and no longer used. In `directorySyncSection`, `primaryButton__startConfiguration` is renamed to `primaryButton__configure` and `badge__unconfigured` is removed. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1392,14 +1392,13 @@ export const esCR: LocalizationResource = { | |
| badge__active: undefined, | ||
| badge__inactive: undefined, | ||
| badge__ssoRequired: undefined, | ||
| badge__unconfigured: undefined, | ||
| description: undefined, | ||
| error__load: undefined, | ||
| menuAction__activate: undefined, | ||
| menuAction__deactivate: undefined, | ||
| menuAction__edit: undefined, | ||
| menuAction__remove: undefined, | ||
| primaryButton__startConfiguration: undefined, | ||
| primaryButton__configure: undefined, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win Add Spanish translations for the new Configure labels. Both locale resources leave the Directory Sync and SSO
As per path instructions: “If you notice missing translations for new keys, flag them for completion.” 📍 Affects 2 files
🤖 Prompt for AI AgentsSource: Path instructions |
||
| removeDialog: { | ||
| confirmButton: undefined, | ||
| subtitle: undefined, | ||
|
|
@@ -1471,6 +1470,7 @@ export const esCR: LocalizationResource = { | |
| menuAction__edit: undefined, | ||
| menuAction__remove: undefined, | ||
| primaryButton__addConnection: undefined, | ||
| primaryButton__configure: undefined, | ||
| primaryButton__continueConfiguration: undefined, | ||
| primaryButton__startConfiguration: undefined, | ||
| title: undefined, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1393,14 +1393,13 @@ export const esMX: LocalizationResource = { | |
| badge__active: undefined, | ||
| badge__inactive: undefined, | ||
| badge__ssoRequired: undefined, | ||
| badge__unconfigured: undefined, | ||
| description: undefined, | ||
| error__load: undefined, | ||
| menuAction__activate: undefined, | ||
| menuAction__deactivate: undefined, | ||
| menuAction__edit: undefined, | ||
| menuAction__remove: undefined, | ||
| primaryButton__startConfiguration: undefined, | ||
| primaryButton__configure: undefined, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win The new Security-page Configure labels lack Spanish translations. Both locale files set the Directory Sync and SSO
As per path instructions, “If you notice missing translations for new keys, flag them for completion.” 📍 Affects 2 files
🤖 Prompt for AI AgentsSource: Path instructions |
||
| removeDialog: { | ||
| confirmButton: undefined, | ||
| subtitle: undefined, | ||
|
|
@@ -1472,6 +1471,7 @@ export const esMX: LocalizationResource = { | |
| menuAction__edit: undefined, | ||
| menuAction__remove: undefined, | ||
| primaryButton__addConnection: undefined, | ||
| primaryButton__configure: undefined, | ||
| primaryButton__continueConfiguration: undefined, | ||
| primaryButton__startConfiguration: undefined, | ||
| title: undefined, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Add translations for the new Configure labels.
Both locale resources set the new Configure labels to
undefined, so they do not provide Bengali or Catalan text for these buttons.packages/localizations/src/bn-IN.ts#L1405-L1405: Add a Bengali translation fordirectorySyncSection.primaryButton__configure.packages/localizations/src/bn-IN.ts#L1477-L1477: Add a Bengali translation forssoSection.primaryButton__configure.packages/localizations/src/ca-ES.ts#L1405-L1405: Add a Catalan translation fordirectorySyncSection.primaryButton__configure.packages/localizations/src/ca-ES.ts#L1477-L1477: Add a Catalan translation forssoSection.primaryButton__configure.As per path instructions: “If you notice missing translations for new keys, flag them for completion.”
📍 Affects 2 files
packages/localizations/src/bn-IN.ts#L1405-L1405(this comment)packages/localizations/src/bn-IN.ts#L1477-L1477packages/localizations/src/ca-ES.ts#L1405-L1405packages/localizations/src/ca-ES.ts#L1477-L1477🤖 Prompt for AI Agents
Source: Path instructions