Skip to content

feat(mosaic): add shared table toolbar and search - #9915

Merged
austincalvelage merged 2 commits into
mainfrom
austin/table-toolbar-search
Sep 24, 2026
Merged

austincalvelage merged 2 commits into
mainfrom
austin/table-toolbar-search

Conversation

@austincalvelage

@austincalvelage austincalvelage commented Sep 24, 2026 •

Copy link
Copy Markdown
Member

Description

Adds Table.Toolbar, controlled Table.Search, and Table.Cell noWrap to share table controls and date-cell styling. Search composes the existing InputGroup, Icon, and Button, and restores input focus when cleared.

Uses the shared toolbar across all five searchable Mosaic tables: organization Members, Invitations, Requests, and the organization and user API key panels. Adds a working Swingset example and documentation. In Swingset, search and clear each table, then check pagination, selection, and focus after removing a row.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-bot Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 205297c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Sep 24, 2026 5:19pm UTC
swingset Ready Ready Preview Sep 24, 2026 5:19pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Team

Run ID: bd9ceeb7-ccf6-412b-a943-c90ef0a8d525

📥 Commits

Reviewing files that changed from the base of the PR and between 0df733b and 205297c.

📒 Files selected for processing (21)
  • .changeset/tidy-tables-search.md
  • packages/mosaic/src/components/table/index.ts
  • packages/mosaic/src/components/table/table.styles.ts
  • packages/mosaic/src/components/table/table.test.tsx
  • packages/mosaic/src/components/table/table.tsx
  • packages/mosaic/src/features/organization-profile/invitations-table-tab.styles.ts
  • packages/mosaic/src/features/organization-profile/invitations-table-tab.view.tsx
  • packages/mosaic/src/features/organization-profile/members-table-tab.styles.ts
  • packages/mosaic/src/features/organization-profile/members-table-tab.view.tsx
  • packages/mosaic/src/features/organization-profile/organization-profile-api-keys-panel.styles.ts
  • packages/mosaic/src/features/organization-profile/organization-profile-api-keys-panel.view.tsx
  • packages/mosaic/src/features/organization-profile/requests-table-tab.styles.ts
  • packages/mosaic/src/features/organization-profile/requests-table-tab.view.tsx
  • packages/mosaic/src/features/user-profile/user-profile-api-keys-panel.styles.ts
  • packages/mosaic/src/features/user-profile/user-profile-api-keys-panel.view.tsx
  • packages/swingset/src/lib/registry.ts
  • packages/swingset/src/stories/organization-profile-api-keys-panel.mdx
  • packages/swingset/src/stories/organization-profile-members-panel.mdx
  • packages/swingset/src/stories/table.mdx
  • packages/swingset/src/stories/table.stories.tsx
  • packages/swingset/src/stories/user-profile-api-keys-panel.mdx
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go (manual)
  • clerk/dashboard (manual)
  • clerk/accounts (manual)
  • clerk/backoffice (manual)
  • clerk/clerk (manual)
  • clerk/clerk-docs (manual)
  • clerk/cloudflare-workers (manual)
  • clerk/cli (auto-detected)
  • clerk/clerk-ios (auto-detected)
  • clerk/clerk-android (auto-detected)
💤 Files with no reviewable changes (7)
  • packages/mosaic/src/features/organization-profile/invitations-table-tab.styles.ts
  • packages/mosaic/src/features/user-profile/user-profile-api-keys-panel.styles.ts
  • packages/mosaic/src/features/organization-profile/members-table-tab.styles.ts
  • packages/swingset/src/stories/user-profile-api-keys-panel.mdx
  • packages/swingset/src/stories/organization-profile-api-keys-panel.mdx
  • packages/mosaic/src/features/organization-profile/requests-table-tab.styles.ts
  • packages/mosaic/src/features/organization-profile/organization-profile-api-keys-panel.styles.ts

Included review availability: 7 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 8 reviews per hour.


📝 Walkthrough

Walkthrough

The table package adds Table.Toolbar and controlled Table.Search components, plus a noWrap option for table cells. Five organization and user profile tables replace custom search controls and date-cell styles with these shared table features. Tests, table documentation, and a registered Search story are added or updated.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Suggested reviewers: alexcarpenter

Merge Risk: ⚪ Minimal · up to 20529

The shared table controls are ready to merge after normal checks; no blocking issue was identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 10 functions across 11 files. (3 skipped: … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding a shared table toolbar and search to Mosaic.
Description check ✅ Passed The description directly covers the new table components, their adoption across searchable tables, tests, documentation, and expected behavior.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 10 functions across 11 files. (3 skipped: 3 unsupported.)

  • Fix all pre-merge checks with AI

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9915

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9915

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9915

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9915

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9915

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9915

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9915

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9915

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@9915

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9915

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9915

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9915

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9915

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9915

@clerk/mosaic

npm i https://pkg.pr.new/@clerk/mosaic@9915

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9915

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9915

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9915

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9915

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9915

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9915

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9915

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9915

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9915

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9915

commit: 205297c

@austincalvelage
austincalvelage merged commit 1fba62d into main Sep 24, 2026
54 of 84 checks passed
@austincalvelage
austincalvelage deleted the austin/table-toolbar-search branch September 24, 2026 17:31

This branch was successfully deployed

2 active deployments
Preview – swingset — 205297c0 Deployed Sep 24, 2026 by vercel[bot]
Preview – clerk-js-sandbox — 205297c0 Deployed Sep 24, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants