Skip to content

test(tanstack-react-start): match reworded missing secret key error - #9908

Merged
manovotny merged 2 commits into
mainfrom
manovotny/fix-tanstack-loadoptions-test
Sep 23, 2026
Merged

manovotny merged 2 commits into
mainfrom
manovotny/fix-tanstack-loadoptions-test

Conversation

@manovotny

@manovotny manovotny commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Description

main is failing the Unit Tests (**) job in @clerk/tanstack-react-start's loadOptions.test.ts and the Integration Tests (tanstack-react-start) job in keyless.test.ts.

#9848 dropped npx clerk@latest init from the missing secret key error, which now points to npx clerk@latest link for an existing app. #9578 merged after it with tests still expecting init. Both tests now match the reworded error.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other: test fix

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 832033f)
@changeset-bot

changeset-bot Bot commented Sep 23, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 3091482

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Sep 23, 2026 9:42pm UTC
swingset Ready Ready Preview Sep 23, 2026 9:42pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Team

Run ID: 02c8201e-614c-468f-b4a5-4cc17445815d

📥 Commits

Reviewing files that changed from the base of the PR and between 3091482 and 876239e.

📒 Files selected for processing (1)
  • integration/tests/tanstack-start/keyless.test.ts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go (manual)
  • clerk/dashboard (manual)
  • clerk/accounts (manual)
  • clerk/backoffice (manual)
  • clerk/clerk (manual)
  • clerk/clerk-docs (manual)
  • clerk/cloudflare-workers (manual)
  • clerk/cli (auto-detected)
  • clerk/clerk-ios (auto-detected)
  • clerk/clerk-android (auto-detected)

Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 6 reviews per hour.


📝 Walkthrough

Walkthrough

The server test and integration test now expect missing-secret-key guidance to include npx clerk@latest link instead of npx clerk@latest init. A changeset file with two --- delimiter lines and no other content was added.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: djgould

Merge Risk: ⚪ Minimal · up to 87623

The PR is ready to merge; it aligns both expectations with the updated command guidance.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the test updates for the reworded missing secret key error. It matches the primary changes.
Description check ✅ Passed The description explains the stale test expectations, the updated command guidance, and the affected tests. It directly matches the changeset.

Comment @coderabbitai help to get the list of available commands.

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR

@pkg-pr-new

pkg-pr-new Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9908

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9908

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9908

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9908

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9908

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9908

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9908

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9908

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@9908

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9908

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9908

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9908

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9908

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9908

@clerk/mosaic

npm i https://pkg.pr.new/@clerk/mosaic@9908

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9908

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9908

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9908

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9908

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9908

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9908

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9908

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9908

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9908

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9908

commit: 876239e

@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-09-23T21:42:13.552Z

Summary

Metric Count
Packages analyzed 19
Packages with changes 0
🔴 Breaking changes 0
🟡 Non-breaking changes 0
🟢 Additions 0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 876239e.

…s test

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@manovotny
manovotny merged commit 32d031b into main Sep 23, 2026
117 of 119 checks passed
@manovotny
manovotny deleted the manovotny/fix-tanstack-loadoptions-test branch September 23, 2026 22:09

This branch was successfully deployed

2 active deployments
Preview – swingset — 876239e1 Deployed Sep 23, 2026 by vercel[bot]
Preview – clerk-js-sandbox — 876239e1 Deployed Sep 23, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants