Skip to content

fix(expo): guard useOAuth against a missing verification redirect URL - #9874

Merged
wobsoriano merged 1 commit into
mainfrom
rob/mobile-641-expo-deprecated-useoauth-crashes-on-null
Sep 23, 2026
Merged

wobsoriano merged 1 commit into
mainfrom
rob/mobile-641-expo-deprecated-useoauth-crashes-on-null

Conversation

@wobsoriano

Copy link
Copy Markdown
Member

Description

The deprecated useOAuth() hook called .toString() on the external verification redirect URL without checking for null, so a missing URL crashed the app instead of surfacing a Clerk error. This adds the same guard useSSO() already has.

Resolves MOBILE-641

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-bot Bot commented Sep 22, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 7fb0488

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Sep 22, 2026 9:53pm UTC
swingset Ready Ready Preview Sep 22, 2026 9:53pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Team

Run ID: 37925b00-8c13-45ea-a8a9-aa54ef26a257

📥 Commits

Reviewing files that changed from the base of the PR and between b3ea996 and 7fb0488.

📒 Files selected for processing (2)
  • .changeset/expo-use-oauth-missing-redirect-url.md
  • packages/expo/src/hooks/useOAuth.ts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go (manual)
  • clerk/dashboard (manual)
  • clerk/accounts (manual)
  • clerk/backoffice (manual)
  • clerk/clerk (manual)
  • clerk/clerk-docs (manual)
  • clerk/cloudflare-workers (manual)
  • clerk/cli (auto-detected)
  • clerk/clerk-ios (auto-detected)
  • clerk/clerk-android (auto-detected)

Included review availability: 8 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.


📝 Walkthrough

Walkthrough

The OAuth flow now checks for externalVerificationRedirectURL before opening an Expo auth session. If the URL is missing, it throws a Clerk error. A changeset records a patch release for @clerk/expo.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Severity of issue fixed: Low

Merge Risk: ⚪ Minimal · up to 7fb04

OAuth attempts without a verification redirect URL now fail with a Clerk error instead of crashing. No actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (1 skipped: 1… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the useOAuth() guard for a missing verification redirect URL, which is the main change.
Description check ✅ Passed The description explains the missing-URL crash and the guard added to surface a Clerk error.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Sep 22, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9874

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9874

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9874

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9874

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9874

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9874

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9874

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9874

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@9874

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9874

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9874

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9874

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9874

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9874

@clerk/mosaic

npm i https://pkg.pr.new/@clerk/mosaic@9874

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9874

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9874

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9874

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9874

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9874

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9874

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9874

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9874

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9874

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9874

commit: 7fb0488

@github-actions

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-09-22T21:55:22.022Z

Summary

Metric Count
Packages analyzed 19
Packages with changes 0
🔴 Breaking changes 0
🟡 Non-breaking changes 0
🟢 Additions 0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 7fb0488.

@wobsoriano
wobsoriano merged commit 4d7fa61 into main Sep 23, 2026
78 of 90 checks passed
@wobsoriano
wobsoriano deleted the rob/mobile-641-expo-deprecated-useoauth-crashes-on-null branch September 23, 2026 01:31

This branch was successfully deployed

2 active deployments
Preview – swingset — 7fb04888 Deployed Sep 22, 2026 by vercel[bot]
Preview – clerk-js-sandbox — 7fb04888 Deployed Sep 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants