Skip to content

feat(mosaic): default Profile.NavItem badges to neutral via BadgeContext - #9860

Merged
prestonwebdev merged 2 commits into
prestonwebdev/mosaic-profile-nav-badgefrom
carp/badge-context
Sep 22, 2026
Merged

prestonwebdev merged 2 commits into
prestonwebdev/mosaic-profile-nav-badgefrom
carp/badge-context

Conversation

@alexcarpenter

Copy link
Copy Markdown
Member

Description

Stacked on #9856.

Adds a BadgeContext to Mosaic so a parent can set a default color for the Badges rendered inside it, following the ButtonContext pattern. An explicit color on the Badge still wins.

Profile.NavItem provides color: 'neutral', so a nav item badge can be written as:

<Profile.NavItem value='security' badge={<Badge>2</Badge>}>

The Profile swingset docs and stories drop the now-redundant color='neutral'.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel

vercel Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Sep 22, 2026 2:41pm UTC
swingset Ready Ready Preview Sep 22, 2026 2:41pm UTC

Request Review

@changeset-bot

changeset-bot Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a6a21ee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Team

Run ID: 58c4fef1-552b-49e6-88f1-484df265e417

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@prestonwebdev prestonwebdev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@prestonwebdev
prestonwebdev merged commit 3585b35 into prestonwebdev/mosaic-profile-nav-badge Sep 22, 2026
10 checks passed
@prestonwebdev
prestonwebdev deleted the carp/badge-context branch September 22, 2026 15:18

This branch was successfully deployed

2 active deployments
Preview – swingset — a6a21eef Deployed Sep 22, 2026 by vercel[bot]
Preview – clerk-js-sandbox — a6a21eef Deployed Sep 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants