feat(ui,clerk-js,shared,localizations): Add all members of a role to the SSO allow list - #9826
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 8 reviews per hour. 📝 WalkthroughWalkthroughThe SSO bypass allowlist now supports additions by email or organization role. A bulk API accepts user IDs in batches of up to 100 and returns created entries and per-user errors. The organization profile collects role members, filters existing allowlist entries, and displays added and skipped results. Localization types and locale resources define the updated form and result messages. Appearance handles, password-manager attributes, bundle limits, role-label formatting, and release notes were also updated. Priority: ➖ Normal Estimated code review effort: 4 (Complex) | ~60 minutes Merge Risk: 🔵 Low · up to Adding members by email or role works as intended. If a later batch fails during a large role-based addition, the page shows an error instead of reporting the members already added. The table still refreshes to show them. Arabic and Traditional Chinese users will not see translated text for the new controls and messages. These issues are limited and can be merged with owner awareness or a quick follow-up. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
🦋 Changeset detectedLatest commit: 4ea108e The changes in this PR will be included in the next version bump. This PR includes changesets to release 23 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
4d3fc70 to
5899c02
Compare
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-google-signin
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/mosaic
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
5899c02 to
8fd775a
Compare
bdf0d0d to
e63703b
Compare
e63703b to
75c94d0
Compare
dd7726e to
f19874c
Compare
f19874c to
95c6c36
Compare
95c6c36 to
e88bd57
Compare
dstaley
left a comment
There was a problem hiding this comment.
approved, let's just remove the deprecated localization keys since this feature wasn't ever enabled from the backend
e88bd57 to
9d01315
Compare
… email or by role The Add members card offers an Email tab for a single address and a Role tab that adds everyone with that role through the new bulk route, in batches of 100. When nothing could be added the card keeps the form open and says why, below the field; when some were added it moves to a success step that reports the skipped ones in a warning. Role member counts load through useFetch and only once the Role tab is open, and RoleSelect gains a formatLabel hook so the count survives a localized role name. The email lookup pages through search results until it finds an exact match. The allowlist hook refetches even when a batch fails so committed additions show up. On the Security tab the allow list count sits inline with its menu. The member picker's localization keys from 4.18.0 are removed; the feature was never enabled for anyone. The bulk code pushes two bundles past their bundlewatch budgets; pnpm bundlewatch:fix raised them. Inputs flagged ignorePasswordManager now also opt out of Bitwarden, LastPass and Dashlane.
9d01315 to
4ea108e
Compare
Description
Allowlisting everyone with a role, every admin for example, meant picking members one at a time on the SSO allow list page.
The "Add members" card now has two tabs. Email takes a single address and adds that member. Role lists the organization's roles with their member counts; picking one adds everyone with that role who is not on the list yet, through the bulk route from clerk/clerk_go#22265 in batches of 100. Members whose email address is not served by one of the organization's connections are skipped by the backend, and the page reports how many were added and how many skipped.
For custom flows,
organization.ssoBypassAllowlistgainsaddUsers({ userIds }), returning the added entries and the users that could not be added with the reason.Resolves ORGS-1852.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change