Skip to content

feat(mosaic): confirm before signing out of all devices - #9823

Merged
maxyinger merged 1 commit into
mainfrom
max/sign-out-all-confirmation
Sep 18, 2026
Merged

maxyinger merged 1 commit into
mainfrom
max/sign-out-all-confirmation

Conversation

@maxyinger

@maxyinger maxyinger commented Sep 18, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Follow-up to #9800. Sign out of all devices now triggers a confirmation dialog

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

The widest-reaching action in the section fired on a single press. It now
asks first, naming how many devices it covers, and holds its pending and
failure states in the dialog rather than under the row.

The dialog is mounted outside the card it empties: confirming unmounts
that card, trigger included, which would take the dialog with it before
it could return focus. Focus lands on the current device instead, and on
the trigger when the confirmation is cancelled.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@vercel

vercel Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Sep 18, 2026 3:10pm UTC
swingset Ready Ready Preview Sep 18, 2026 3:10pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Team

Run ID: d2fbb23c-3503-48ca-a61f-fed6a34217c4

📥 Commits

Reviewing files that changed from the base of the PR and between 07b4c2b and ccbb46f.

📒 Files selected for processing (5)
  • .changeset/sign-out-all-confirmation.md
  • packages/mosaic/src/features/user-profile/__tests__/user-profile-device-actions.test.tsx
  • packages/mosaic/src/features/user-profile/__tests__/user-profile-security-panel.view.test.tsx
  • packages/mosaic/src/features/user-profile/user-profile-active-devices-section.view.tsx
  • packages/mosaic/src/features/user-profile/user-profile-active-devices.messages.ts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go (manual)
  • clerk/dashboard (manual)
  • clerk/accounts (manual)
  • clerk/backoffice (manual)
  • clerk/clerk (manual)
  • clerk/clerk-docs (manual)
  • clerk/cloudflare-workers (manual)
  • clerk/cli (auto-detected)
  • clerk/clerk-ios (auto-detected)
  • clerk/clerk-android (auto-detected)

Included review availability: 9 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.


📝 Walkthrough

Walkthrough

The all-devices sign-out action now opens a localized confirmation dialog. The dialog reports the affected device count, supports cancellation and retry after failure, prevents duplicate submissions during the request, and closes after success. Focus returns to the current device after removal or to the trigger after cancellation. Tests cover the updated flow and focus behavior.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to ccbb4

The confirmation flow’s stated behavior has no identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 4 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly states that the pull request adds a confirmation dialog before signing out of all devices. This matches the changeset and objectives.
Title check ✅ Passed The title clearly and concisely identifies the main change: adding confirmation before signing out of all devices.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 4 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI

Comment @coderabbitai help to get the list of available commands.

@changeset-bot

changeset-bot Bot commented Sep 18, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ccbb46f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9823

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9823

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9823

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9823

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9823

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9823

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9823

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9823

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@9823

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9823

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9823

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9823

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9823

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9823

@clerk/mosaic

npm i https://pkg.pr.new/@clerk/mosaic@9823

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9823

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9823

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9823

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9823

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9823

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9823

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9823

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9823

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9823

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9823

commit: ccbb46f

@maxyinger
maxyinger marked this pull request as ready for review September 18, 2026 15:13
@maxyinger
maxyinger merged commit 784f00b into main Sep 18, 2026
57 of 84 checks passed
@maxyinger
maxyinger deleted the max/sign-out-all-confirmation branch September 18, 2026 18:55

This branch was successfully deployed

2 active deployments
Preview – swingset — ccbb46f9 Deployed Sep 18, 2026 by vercel[bot]
Preview – clerk-js-sandbox — ccbb46f9 Deployed Sep 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants