-
Notifications
You must be signed in to change notification settings - Fork 474
feat(ui,clerk-js,shared,react,localizations): Rename the SSO fallback sign-in flow to SSO bypass #9822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui,clerk-js,shared,react,localizations): Rename the SSO fallback sign-in flow to SSO bypass #9822
Changes from all commits
f1f6ec1
a35b987
855bf7d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| --- | ||
| '@clerk/localizations': minor | ||
| '@clerk/clerk-js': minor | ||
| '@clerk/shared': minor | ||
| '@clerk/react': minor | ||
| '@clerk/ui': minor | ||
| --- | ||
|
|
||
| Rename the SSO fallback sign-in flow to SSO bypass, matching the name the feature ships under. The sign-in resource's `ssoFallbackFirstFactors` is now `ssoBypassFirstFactors` and reads the `sso_bypass_first_factors` field from the API, the `signIn.ssoFallback` localization keys are now `signIn.ssoBypass`, and the `ssoFallback` card action element id is now `ssoBypass`. The flow has not been enabled on any instance, so no application is affected by the old names going away. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win 🔎 Supported by static analysis🏁 Script executed on selected repositories: #!/bin/bash
set -eu
echo '--- clerk/dashboard: old/new flag references ---'
rg -n -C 3 'allow_sso_(fallback|bypass)' --glob '!node_modules' --glob '!dist' . | head -240
echo '--- clerk/clerk_go: old/new flag references ---'
rg -n -C 3 'allow_sso_(fallback|bypass)' --glob '!vendor' --glob '!tmp' . | head -240Repositories: clerk/dashboard, clerk/clerk_go Length of output: 33062 🏁 Script executed: #!/bin/bash
set -eu
rg -n -C 5 'function useFeatureFlag|const useFeatureFlag|export .*useFeatureFlag|useFeatureFlag\s*=' apps/dashboard/app apps/dashboard/packages packages 2>/dev/null | head -240Repository: clerk/dashboard Length of output: 1183 🏁 Script executed: #!/bin/bash
set -eu
sed -n '59,82p' apps/dashboard/app/features/featureFlags/FeatureFlagProvider.tsxRepository: clerk/dashboard Length of output: 911 Update the dashboard feature-flag rollout. The dashboard SSO bypass card reads 🧰 Tools🪛 markdownlint-cli2 (0.23.2)[warning] 9-9: First line in a file should be a top-level heading (MD041, first-line-heading, first-line-h1) 🤖 Prompt for AI AgentsSource: Linked repositories |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟠 Major | 🏗️ Heavy lift
🔎 Supported by static analysis
🏁 Script executed:
Repository: clerk/javascript
Length of output: 10817
🏁 Script executed:
Repository: clerk/javascript
Length of output: 33554
🏁 Script executed:
Repository: clerk/javascript
Length of output: 37932
Publish the released API rename as a major change.
The package changelogs for
@clerk/clerk-js@6.32.0,@clerk/shared@4.32.0,@clerk/ui@1.33.0, and@clerk/localizations@4.17.0document these identifiers as consumer-facing functionality. The feature being disabled on some instances does not make the exported identifiers experimental or private. Removing them breaks custom flows and other consumers that use the released names.AGENTS.mdrequires backward compatibility for non-major@clerk/clerk-jsand@clerk/uireleases. Keep deprecated aliases until a major release, or mark each affected package as major and include migration guidance.🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can keep it minor cc @dstaley no customer is using this feature, so there's nobody to break