feat(mosaic): add inset outline to Avatar with a bordered prop - #9815
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 6d70b30 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (6)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour. 📝 WalkthroughWalkthrough
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: Merge Risk: ⚪ Minimal · up to The new Avatar outline option is documented and tested for its default and opt-out behavior. No actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 4 files. (2 skipped: 2 unsupported.)
Comment |
8b834c9 to
6d70b30
Compare
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-google-signin
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/mosaic
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
maxyinger
left a comment
There was a problem hiding this comment.
80 line pr to add a 1px border. sheesh.
Description
Adds a 1px inset outline to the Mosaic Avatar so a photo or fallback that shares the page's background still reads as a bounded shape. The line is drawn with
outlineand a-1pxoffset onAvatar.ImageandAvatar.Fallback, so it never shrinks the box and never collides with the focus ring on an interactive root.Figma's
border-overlayhas no Mosaic token, so the colour is--cl-color-neutral-alpha-100: the translucent twin of--cl-color-border, which lands at the same weight over a matching background and still shows over an image.Avatar.Rootgains aborderedprop (defaulttrue, reflected asdata-bordered) so a consumer can drop the outline. Swingset gets the knob and the prop docs.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change