fix(swingset): point the StyleX PostCSS plugin at the Mosaic source - #9811
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 1767ddf The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
Included review availability: 1 review is currently available. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour. 📝 WalkthroughWalkthroughThe Swingset PostCSS configuration now includes TypeScript and TSX sources from both the local Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The configuration covers the executable Swingset story sources; the MDX files contain documentation examples rather than omitted runtime styles. The change is ready to merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
314595f to
1767ddf
Compare
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-google-signin
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/mosaic
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
Description
Since #9765 extracted Mosaic into
@clerk/mosaic, production builds of Swingset render every Mosaic component unstyled (the Vercel previews show bare text).next devis unaffected because the unplugin'sruntimeInjectioninjects atoms and token defaults at runtime.Swingset's
@stylexjs/postcss-pluginwas relying on auto-discovery to find the Mosaic source: it scans any direct dependency whose manifest lists@stylexjs/stylexunderdependencies,peerDependencies, oroptionalDependencies.@clerk/uidid, sopackages/ui/src(Mosaic included) was scanned.@clerk/mosaickeeps StyleX indevDependencies, since tsdown inlines it into the published bundle, so the plugin skipped the package, scanned nothing, and replaced@stylex;with an empty sheet.This gives the plugin an explicit
includecovering Swingset's own stories andpackages/mosaic/src, so extraction no longer depends on how@clerk/mosaicdeclares its dependencies.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change