Repository navigation
feat(ui): rebuild Mosaic Dialog on bring-your-own surfaces #9772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
fd960d1
feat(ui): rebuild Mosaic Dialog on bring-your-own surfaces
maxyinger 5ec3546
docs(swingset): rebuild the Dialog docs on card surfaces
maxyinger 7ba3ad1
feat(ui): remove inline dialogs and rename closedBy to dismissOn
maxyinger 13217f1
feat(ui): rename the Dialog size prop to variant
maxyinger 753e16f
docs(repo): keep rationale out of the swingset component docs
maxyinger 6e28376
fix(ui): align profile dialogs with dialog refinements
austincalvelage 9ddcade
fix(ui): correct Mosaic dialog warnings and documentation
austincalvelage 4d27100
docs(ui): correct Mosaic dialog and profile guidance
austincalvelage 2d205a4
fix(swingset): reset stacked dialog draft on dismissal
austincalvelage 536cef3
test(ui): strengthen dialog scrim assertions and name fixtures
austincalvelage b16d1a7
fix(ui): refresh accessibility warnings when part names change
austincalvelage be1776c
fix(swingset): label dialog inputs and require sheet email
austincalvelage e5f2320
fix(ui): omit profile close button in alert dialogs
austincalvelage 1081436
Merge branch 'main' into max/mosaic-dialog-refinements
austincalvelage 8e55624
feat(ui): derive dialog dismissal from the role instead of a prop
maxyinger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| --- | ||
| --- | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.