Skip to content

fix(ui): reconnect Google One Tap accounts through Google OAuth - #9767

Merged
wobsoriano merged 1 commit into
mainfrom
rob/fix-google-one-tap-reconnect
Sep 16, 2026
Merged

wobsoriano merged 1 commit into
mainfrom
rob/fix-google-one-tap-reconnect

Conversation

@wobsoriano

@wobsoriano wobsoriano commented Sep 15, 2026 •

Copy link
Copy Markdown
Member

Description

Fixes #9689

Reopens #9690 by @akshitkrnagpal so CI can run. CI does not run on external contributions and only specific users can force merge. Refer to #9690 for more info.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Preserve session reverification when reconnecting in UserProfile.

Co-authored-by: Akshit Kr Nagpal <akshitkrnagpal@gmail.com>
@vercel

vercel Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Sep 15, 2026 4:24pm UTC
swingset Ready Ready Preview Sep 15, 2026 4:24pm UTC

Request Review

@changeset-bot

changeset-bot Bot commented Sep 15, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: bd45e13

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/ui Patch
@clerk/chrome-extension Patch
@clerk/swingset Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added the ui label Sep 15, 2026
@coderabbitai

coderabbitai Bot commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Team

Run ID: a4c7e79e-4041-4692-8143-1b6de6f0ffc4

📥 Commits

Reviewing files that changed from the base of the PR and between cf60413 and bd45e13.

📒 Files selected for processing (3)
  • .changeset/early-crabs-obey.md
  • packages/ui/src/components/UserProfile/ConnectedAccountsSection.tsx
  • packages/ui/src/components/UserProfile/__tests__/ConnectedAccountsSection.test.tsx
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go (manual)
  • clerk/dashboard (manual)
  • clerk/accounts (manual)
  • clerk/backoffice (manual)
  • clerk/clerk (manual)
  • clerk/clerk-docs (manual)
  • clerk/cloudflare-workers (manual)
  • clerk/cli (auto-detected)
  • clerk/clerk-ios (auto-detected)
  • clerk/clerk-android (auto-detected)

Included review availability: 9 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.


📝 Walkthrough

Walkthrough

ConnectedAccount now converts google_one_tap to oauth_google when reconnecting an external account. Existing strategies and provider fallbacks remain unchanged. Tests cover initial requests, session reverification errors, retries, and navigation for both Google One Tap and Google OAuth strategies. A patch changeset documents the fix for @clerk/ui.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Severity of issue fixed: Medium

Suggested reviewers: alexcarpenter

Merge Risk: ⚪ Minimal · up to bd45e

The reconnection change has targeted regression coverage for both initial and reverification retry flows, with no remaining concrete merge-blocking concern identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly explains the Google One Tap reconnection fix, the OAuth strategy normalization, and preservation of session reverification.
Title check ✅ Passed The title clearly and concisely identifies the main change: reconnecting Google One Tap accounts through Google OAuth.
Linked Issues check ✅ Passed The change meets the coding requirements in [#9689]. ConnectedAccountsSection maps google_one_tap to oauth_google and preserves the existing fallback for other strategies. The added parameterize…
Out of Scope Changes check ✅ Passed The changes stay within the issue scope. They modify the reconnect strategy, add regression coverage for the initial and retry requests, and add a patch changeset for @clerk/ui. No unrelated product…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Sep 15, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9767

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9767

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9767

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9767

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9767

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9767

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9767

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9767

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@9767

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9767

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9767

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9767

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9767

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9767

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9767

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9767

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9767

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9767

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9767

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9767

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9767

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9767

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9767

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9767

commit: bd45e13

@github-actions

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-09-15T16:26:13.247Z

Summary

Metric Count
Packages analyzed 19
Packages with changes 0
🔴 Breaking changes 0
🟡 Non-breaking changes 0
🟢 Additions 0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on bd45e13.

@wobsoriano
wobsoriano merged commit 9160e6c into main Sep 16, 2026
87 of 88 checks passed
@wobsoriano
wobsoriano deleted the rob/fix-google-one-tap-reconnect branch September 16, 2026 13:42

This branch was successfully deployed

2 active deployments
Preview – swingset — bd45e13c Deployed Sep 15, 2026 by vercel[bot]
Preview – clerk-js-sandbox — bd45e13c Deployed Sep 15, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UserProfile reconnect sends google_one_tap instead of oauth_google for Google One Tap accounts

2 participants