fix(ui): route modal SSO callbacks to the sign-in sso-callback route - #9758
Conversation
🦋 Changeset detectedLatest commit: fc7fe29 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (4)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
Included review availability: 9 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour. 📝 WalkthroughWalkthrough
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to Modal OAuth sign-up callbacks now target the mounted sign-in callback route, with no actionable current-head risk identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Warning Linked repositories: Your configuration references 7 linked repositories, but your current plan allows 5. Analyzed Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
a4dec97 to
afb4017
Compare
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-google-signin
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
… unmounted create route
afb4017 to
e0cfd77
Compare
a0d4ce0 to
f35f48c
Compare
API Changes Report
Summary
No API Changes DetectedAll packages have stable APIs with no detected changes. Report generated by Break Check Last ran on |
Description
Fixes OAuth and Enterprise SSO sign-ups for new users started from
openSignIn({ withSignUp: true })or<SignInButton mode="modal" withSignUp />.This is introduced by #8385. Before it, the modal never used
ssoCallbackUrlbecausebuildSSOCallbackURLskipped it for virtual routing. The PR deleted that helper to fix the callback's base URL, and the modal inherited the/createprefix with it.The fix keeps #8385's base and drops the
/createprefix for virtual routing only.See slack convo for more info https://clerkinc.slack.com/archives/C07JK3YT2G2/p1789409793222669
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change