Skip to content

fix(ui): route modal SSO callbacks to the sign-in sso-callback route - #9758

Merged
wobsoriano merged 3 commits into
mainfrom
rob/modal-with-signup-sso-callback
Sep 15, 2026
Merged

wobsoriano merged 3 commits into
mainfrom
rob/modal-with-signup-sso-callback

Conversation

@wobsoriano

@wobsoriano wobsoriano commented Sep 14, 2026 •

Copy link
Copy Markdown
Member

Description

Fixes OAuth and Enterprise SSO sign-ups for new users started from openSignIn({ withSignUp: true }) or <SignInButton mode="modal" withSignUp />.

This is introduced by #8385. Before it, the modal never used ssoCallbackUrl because buildSSOCallbackURL skipped it for virtual routing. The PR deleted that helper to fix the callback's base URL, and the modal inherited the /create prefix with it.

The fix keeps #8385's base and drops the /create prefix for virtual routing only.

See slack convo for more info https://clerkinc.slack.com/archives/C07JK3YT2G2/p1789409793222669

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-bot Bot commented Sep 14, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: fc7fe29

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/ui Patch
@clerk/chrome-extension Patch
@clerk/swingset Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Team

Run ID: bd3d2f64-730f-49bd-8d1a-bdd5280a554b

📥 Commits

Reviewing files that changed from the base of the PR and between 53a5463 and fc7fe29.

📒 Files selected for processing (4)
  • .changeset/modal-with-signup-sso-callback.md
  • integration/tests/oauth-flows.test.ts
  • packages/ui/src/components/SignIn/__tests__/SignInSocialButtons.test.tsx
  • packages/ui/src/contexts/components/SignIn.ts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go (manual)
  • clerk/dashboard (manual)
  • clerk/accounts (manual)
  • clerk/backoffice (manual)
  • clerk/clerk (manual)

Included review availability: 9 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.


📝 Walkthrough

Walkthrough

SignIn now uses /sign-in#/sso-callback for combined virtual routing instead of /sign-in#/create/sso-callback. Unit and integration tests cover the callback URL and modal OAuth sign-up flow. The integration test verifies that openSignIn({ withSignUp: true }) creates and authenticates a new OAuth user, then redirects to /protected. A patch changeset documents the fix.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to fc7fe

Modal OAuth sign-up callbacks now target the mounted sign-in callback route, with no actionable current-head risk identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the main change: routing modal SSO callbacks to the sign-in SSO callback route.
Description check ✅ Passed The description directly explains the modal OAuth and Enterprise SSO sign-up fix, its cause, its scope, and the related tests.

Warning

Linked repositories: Your configuration references 7 linked repositories, but your current plan allows 5. Analyzed clerk/clerk_go, clerk/dashboard, clerk/accounts, clerk/backoffice, clerk/clerk, skipped clerk/clerk-docs, clerk/cloudflare-workers.


Comment @coderabbitai help to get the list of available commands.

@vercel

vercel Bot commented Sep 14, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Sep 14, 2026 9:41pm UTC
swingset Ready Ready Preview Sep 14, 2026 9:41pm UTC

Request Review

@pkg-pr-new

pkg-pr-new Bot commented Sep 14, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9758

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9758

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9758

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9758

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9758

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9758

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9758

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9758

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@9758

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9758

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9758

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9758

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9758

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9758

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9758

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9758

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9758

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9758

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9758

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9758

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9758

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9758

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9758

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9758

commit: fc7fe29

@github-actions

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-09-14T21:46:52.638Z

Summary

Metric Count
Packages analyzed 19
Packages with changes 0
🔴 Breaking changes 0
🟡 Non-breaking changes 0
🟢 Additions 0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on fc7fe29.

@wobsoriano
wobsoriano merged commit a3038cb into main Sep 15, 2026
157 of 168 checks passed
@wobsoriano
wobsoriano deleted the rob/modal-with-signup-sso-callback branch September 15, 2026 13:02

This branch was successfully deployed

2 active deployments
Preview – swingset — fc7fe29a Deployed Sep 14, 2026 by vercel[bot]
Preview – clerk-js-sandbox — fc7fe29a Deployed Sep 14, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants